Add fftpack deprecated #1047
Merged
Add fftpack deprecated #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33c8d5f. Conflicts: scimath/CMakeLists.txt scimath_f/CMakeLists.txt
|
Does what it says on the tin. I have successfully built an (almost) current CASA master against this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1040 (comment) , removing FFTPack in 33c8d5f caused the CASA build to break. This PR follows the proposal of @kettenis to add back FFTPack, but with a deprecation warning. It will not be built by default, except in the CASA build setting. Also, it will print a deprecation warning when including
FFTPack.h.Building FFTPack can be enabled at cmake time by setting the option
-DBUILD_FFTPACK_DEPRECATED=True. The default isFalse. WhenCASA_BUILD=True, it will currently beTrueso CASA should build.