-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sofa from casacore, fixes #105 #107
Conversation
we can also package up SOFA, making weekly packages just like casacore-data (measures data) |
A weekly release is definitely not necessary, SOFA has a decent release system (though not a very modern packaging system). It could be packaged whenever SOFA has a release. However, since installing sofa from source it pretty straightforward, see the jenkins script, I don't think we need to package it. |
many packages are quite straightforward to install from source, that doesn't mean you want to do it all the time :) is there only a build time or also a runtime dependency on SOFA? |
There is only a test time dependency on SOFA (and when running the test, it's probably run time). |
ah yes, i mean test time |
Removing SOFA seems to be good for debian packaging as well, since the SOFA license may not be compatible enough with debian's license: |
As you might have seen from the message, the inclusion of SOFA was the reason why the package was rejected by the Debian ftp-masters. In Debian, SOFA is already packaged, but in non-free. However, there is a free replacement available: erfa. Erfa is based on SOFA (and synchronized regularly) and differs only in the license, and in the function prefixes ( |
Let's see if the pull request is accepted. If it is, we don't need to switch to erfa. Tammo Jan
|
Remove sofa from casacore, fixes #105
No description provided.