Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sofa from casacore, fixes #105 #107

Merged
merged 3 commits into from
Jun 11, 2015
Merged

Remove sofa from casacore, fixes #105 #107

merged 3 commits into from
Jun 11, 2015

Conversation

tammojan
Copy link
Contributor

No description provided.

@gijzelaerr
Copy link
Member

we can also package up SOFA, making weekly packages just like casacore-data (measures data)

@tammojan
Copy link
Contributor Author

we can also package up SOFA, making weekly packages just like casacore-data (measures data)

A weekly release is definitely not necessary, SOFA has a decent release system (though not a very modern packaging system). It could be packaged whenever SOFA has a release.

However, since installing sofa from source it pretty straightforward, see the jenkins script, I don't think we need to package it.

@gijzelaerr
Copy link
Member

many packages are quite straightforward to install from source, that doesn't mean you want to do it all the time :)

is there only a build time or also a runtime dependency on SOFA?

@tammojan
Copy link
Contributor Author

is there only a build time or also a runtime dependency on SOFA?

There is only a test time dependency on SOFA (and when running the test, it's probably run time).

@gijzelaerr
Copy link
Member

ah yes, i mean test time

@tammojan
Copy link
Contributor Author

Removing SOFA seems to be good for debian packaging as well, since the SOFA license may not be compatible enough with debian's license:
https://lists.debian.org/debian-astro/2014/11/msg00008.html

@olebole
Copy link
Contributor

olebole commented May 27, 2015

As you might have seen from the message, the inclusion of SOFA was the reason why the package was rejected by the Debian ftp-masters.

In Debian, SOFA is already packaged, but in non-free. However, there is a free replacement available: erfa. Erfa is based on SOFA (and synchronized regularly) and differs only in the license, and in the function prefixes (era instead of iau). Erfa is also packaged for Debian and Ubuntu.
So, iof you feel it is really worth to keep these checks, it may be worth to consider switching to erfa.

@tammojan
Copy link
Contributor Author

Let's see if the pull request is accepted. If it is, we don't need to switch to erfa.

Tammo Jan

Op 27 mei 2015 om 15:09 heeft Ole Streicher notifications@github.com het volgende geschreven:

As you might have seen from the message, the inclusion of SOFA was the reason why the package was rejected by the Debian ftp-masters.

In Debian, SOFA is already packaged, but in non-free. However, there is a free replacement available: erfa. Erfa is based on SOFA (and synchronized regularly) and differs only in the license, and in the function prefixes (era instead of iau). Erfa is also packaged for Debian and Ubuntu.
So, iof you feel it is really worth to keep these checks, it may be worth to consider switching to erfa.


Reply to this email directly or view it on GitHub.

gervandiepen added a commit that referenced this pull request Jun 11, 2015
Remove sofa from casacore, fixes #105
@gervandiepen gervandiepen merged commit d04cf28 into master Jun 11, 2015
@gervandiepen gervandiepen deleted the issue105 branch June 11, 2015 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants