-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array mods #113
Merged
Merged
Array mods #113
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
caf2242
1) Added method reformOrResize to allow Array contain and manage storage
JimNrao 265d1d9
Merge branch 'master' into ArrayMods
JimNrao d009643
Merge branch 'master' of ssh://github.com/casacore/casacore into Arra…
JimNrao 098eb84
Modified Array.{h,tcc} to address Ger's comments on the pull request.
JimNrao c24188b
Moved 95% of the implementation of Array<T>::reformOrReshape to Array…
JimNrao 46b1be7
Reworked API so that there are now two public methods: reformOrResize
JimNrao 4a7f369
Merge branch 'master' of ssh://github.com/casacore/casacore into Arra…
JimNrao 7add7a2
Changed name of "Array<T>::extend" method to "Array<T>::adjustLastAxis".
JimNrao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setEndIter needs to be done by the caller when the array is resized.