Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UVFITS support for large antenna numbers #1144

Merged
merged 1 commit into from Dec 3, 2021

Conversation

kettenis
Copy link
Contributor

Follow the scheme documented in AIPS memo 117 (revised, 19 June 2017)
and use separate SUBARRAY, ANTENNA1 and ANTENNA2 random parameters
when antenna numbers larger than 255 are encountered when writing
UVFITS files.

Add support for reading such UVFITS files back in as well.

@kettenis
Copy link
Contributor Author

With these changes, the OSKAR MS with 512 antennas provided to me by Robert Braun can be exported and can be loaded into AIPS using the FITLD task. The resulting data structures look fine when explored using ParselTongue, but some AIPS tasks are unhappy. I suspect that this is a problem with the characteristics of the data produced by OSKAR. A VLBI data set that has been written in the new format (by forcing the codepath that writes out SUBARRAY, ANTENNA1 and ANTENNA2 instead of BASELINE random parameters) seems to behave just fine.

Converting the OSKAR data set back into MS seems to work as well, with some expected loss of metadata.

The CASA regression tests still pass with this change.

Copy link
Contributor

@tammojan tammojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's no existing unit test that could be used to check the new behavior?

The changes overall look good to me.

msfits/MSFits/MSFitsOutput.cc Show resolved Hide resolved
msfits/MSFits/MSFitsInput.cc Outdated Show resolved Hide resolved
msfits/MSFits/MSFitsInput.cc Outdated Show resolved Hide resolved
msfits/MSFits/MSFitsOutput.cc Show resolved Hide resolved
msfits/MSFits/MSFitsOutput.cc Show resolved Hide resolved
msfits/MSFits/MSFitsOutput.cc Outdated Show resolved Hide resolved
@aroffringa aroffringa changed the title Add support for large antenna numbers Add UVFITS support for large antenna numbers Nov 29, 2021
@kettenis kettenis force-pushed the maxant branch 2 times, most recently from 546c015 to f72e8f0 Compare November 30, 2021 10:10
Follow the scheme documented in AIPS memo 117 (revised, 19 June 2017)
and use separate SUBARRAY, ANTENNA1 and ANTENNA2 random parameters
when antenna numbers larger than 255 are encountered when writing
UVFITS files.

Add support for reading such UVFITS files back in as well.
@kettenis
Copy link
Contributor Author

Pushed a new version with the requested changes. Also adjusted the commit message to match the title change done by @aroffringa

@tammojan tammojan merged commit a30f2ed into casacore:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants