Use 64-bit rownrs in Dysco #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroffringa
approved these changes
Mar 16, 2022
| casacore::rownr_t rowNr, casacore::Array<DataType> *dataArr) { | ||
| // Make sure array storage is contiguous. | ||
| casacore::Bool deleteIt; | ||
| DataType* dataPtr = dataArr->getStorage (deleteIt); |
There was a problem hiding this comment.
Sometime in the future, it would be better to do this using a RAII structure. There are all kind of exceptions possible in the code below, which would lead to leaks. Not really directly a concern now, so no changes required, but maybe for a future MR.
| casacore::uInt rowNr, casacore::Array<DataType> *dataPtr) { | ||
| casacore::rownr_t rowNr, casacore::Array<DataType> *dataArr) { | ||
| // Make sure array storage is contiguous. | ||
| casacore::Bool deleteIt; |
There was a problem hiding this comment.
Would it be possible to start using just bool for new code?
aroffringa
pushed a commit
to aroffringa/dysco
that referenced
this pull request
Mar 16, 2022
This merges the changes from casacore/casacore#1166 back to here, and changes a few other things to be in line with casacore. After merging a new version should be released.
aroffringa
pushed a commit
to aroffringa/dysco
that referenced
this pull request
Mar 16, 2022
This merges the changes from casacore/casacore#1166 back to here, and changes a few other things to be in line with casacore. After merging a new version should be released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dysco storage manager has been changed to use 64-bit row numbers.
Furthermore, it has been assured that the array storage is contiguous by using getStorage.
Close #1139