Fix data race in SpectralCoordinate's toWorld/toPixel #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two functions use a static 1-element Vector to avoid allocations on each invocation; however these static vectors are shared across multiple threads, leading to race conditions on unlocked data access and therefore unexpected results. This commit adds the thread_local specifier on these static variables such that in multi-threaded scenarios each thread ends up with its own static copy of the variable, thus avoiding unlocked data shared across threads. This issue was originally reported in casacore#1200, and then more specifically in casacore#1217. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
gervandiepen
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions use a static 1-element Vector to avoid allocations on each invocation; however these static vectors are shared across multiple threads, leading to race conditions on unlocked data access and therefore unexpected results.
This commit adds the thread_local specifier on these static variables such that in multi-threaded scenarios each thread ends up with its own static copy of the variable, thus avoiding unlocked data shared across threads.
This issue was originally reported in #1200, and then more specifically in #1217.
Signed-off-by: Rodrigo Tobar rtobar@icrar.org