Add Json support for ImageConcat and ImageExpr #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dank u wel, Ger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #505
CASA requested the creation of the ImageConcat and ImageExpr output file in a named directory instead of a named file to be able to move them more easily.
For that purpose it is also more convenient to have the output in text format instead of AipsIO format, so it can be edited if needed. It was chosen to output it in Json format. Code has been created to easily read and write Json files.
This PR is the same is basically the same as #506 with the addition of the .h files to CMakeLists.txt.
It is known to break the CASA build, which has to be changed asap. Also the CASA pipeline feature of moving an ImageConcat file to a directory has to be removed, because ImageConcat now creates (or uses) a directory as agreed with Kumar Golap.