Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cas 11643 Fit2D method to enable casa imfit for Double images #757

Merged
merged 3 commits into from Jul 16, 2018

Conversation

dmehring
Copy link
Contributor

No description provided.

@dmehring
Copy link
Contributor Author

Note that I merged the branch in PR 754 into this branch.

@mpokorny
Copy link
Contributor

Creating branches that include other unmerged branches makes the review more difficult, as previously reviewed changes are mixed in with new changes when reviewing the PRs in order. It might have been better in this case to create just one PR branch and push changes to it a few times. I guess that you might have chosen to do it this way since I was away for a week, although I'm not sure of the benefit. Anyway, the changes look good.

@mpokorny mpokorny merged commit 96428d6 into casacore:master Jul 16, 2018
@dmehring
Copy link
Contributor Author

Thanks Martin. It was the result of how I was working the corresponding branches in CASA, each branch building on the previous, although I suppose I could have created a single composite branch locally and pushed the individual branches separately, although each separate commit amounted to a different branch anyway. But I will keep in mind for the future.

@gijzelaerr gijzelaerr added this to the 2.5 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants