Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give error when casacore is too old #195

Merged
merged 6 commits into from Apr 16, 2020
Merged

Give error when casacore is too old #195

merged 6 commits into from Apr 16, 2020

Conversation

tammojan
Copy link
Contributor

@tammojan tammojan commented Apr 16, 2020

The travis tests using KERN all fail on a unicode error. Probably this was fixed in casacore 3.1.1, which has unicode improvements. I'll bump to KERN5 to see if it helps, but KERN5 has casacore 2.5.0 3.0.0, so probably not.

@pep8speaks
Copy link

pep8speaks commented Apr 16, 2020

Hello @tammojan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 124:9: E722 do not use bare 'except'
Line 243:1: E303 too many blank lines (3)
Line 246:43: E271 multiple spaces after keyword
Line 246:80: E501 line too long (113 > 79 characters)
Line 247:80: E501 line too long (105 > 79 characters)

Comment last updated at 2020-04-16 15:31:22 UTC

@tammojan
Copy link
Contributor Author

I added an error to setup.py to raise an Exception when casacore is detected and the version can be extracted, but it is too old. The result is here:

RuntimeError: Your casacore version is too old. Minimum is 3.1.1, you have 2.5.0

@tammojan tammojan changed the title Bump to KERN 5 in travis Give error when casacore is too old Apr 16, 2020
@tammojan tammojan mentioned this pull request Apr 16, 2020
setup.py Show resolved Hide resolved
@tammojan
Copy link
Contributor Author

Rebased on master. I made an extension to build_ext that will crash if casacore is too old. This should make sure that setup.py can still be run to do e.g. setup.py clean. This is tested in one of the travis jobs.

@tammojan tammojan merged commit 8cb0b45 into master Apr 16, 2020
@tammojan tammojan deleted the bump_travis branch April 16, 2020 18:49
@gijzelaerr
Copy link
Member

hey! nog niet gereviewd :)

@tammojan
Copy link
Contributor Author

Oops...

@gijzelaerr
Copy link
Member

maar ziet er goed uit, mooi zerk. volgens mij zou dit wel moeten werken. laten we zien wat er gebeurt tijdens packagen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants