Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Chainladder doesn't coerce valuation triangle correctly #399

Closed
jbogaardt opened this issue Dec 3, 2022 · 3 comments
Closed

[BUG] Chainladder doesn't coerce valuation triangle correctly #399

jbogaardt opened this issue Dec 3, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@jbogaardt
Copy link
Collaborator

Describe the bug
See offending code below.

To Reproduce
Steps to reproduce the behavior. Code should be self-contained and runnable against publicly available data. For example:

import chainladder as cl
raa = cl.load_sample('raa')
model = cl.Chainladder().fit(raa)
# works 
assert model.predict(raa.latest_diagonal.val_to_dev()).ultimate_ == model.ultimate_
# doesn't work
assert model.predict(raa.latest_diagonal).ultimate_ == model.ultimate_
@jbogaardt jbogaardt added the Bug label Dec 3, 2022
@jbogaardt jbogaardt self-assigned this Dec 3, 2022
jbogaardt pushed a commit that referenced this issue Dec 3, 2022
@jbogaardt jbogaardt added this to the v0.9.0 milestone Dec 3, 2022
@jbogaardt
Copy link
Collaborator Author

Resolved on master, will be in next release.

@tyler-corcoran
Copy link

Resolved on master, will be in next release.

Is this change reflected in the current release? I seem to be having an issue that is likely related.

@jbogaardt
Copy link
Collaborator Author

Not yet, we have not done a release since this went in. Release cadence has slowed somewhat as its my busy season.

If you want to test out the unreleased version and you have git, you should be able to install with:

pip install git+https://github.com/casact/chainladder-python/

This should at least let you see whether your specific issue is addressed with this bug-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants