Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Pandas deprecation notices #510

Closed
jbogaardt opened this issue Apr 11, 2024 · 3 comments · Fixed by #515
Closed

[MAINT] Pandas deprecation notices #510

jbogaardt opened this issue Apr 11, 2024 · 3 comments · Fixed by #515
Assignees

Comments

@jbogaardt
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

There are several pandas deprecation notices with pandas 2.2 and later. These should be handled and silenced. The most common is our usage of the infer_datetime_format.

chainladder/core/base.py:250: UserWarning: The argument 'infer_datetime_format' is deprecated and will be removed in a future version. A strict version of it is now the default, see https://pandas.pydata.org/pdeps/0004-consistent-to-datetime-parsing.html. You can safely remove this argument.

Is your feature request at odds with the scope of the package?
No

Describe the solution you'd like
No pesky deprecation notices regardless of which version of pandas is installed.

@jbogaardt jbogaardt self-assigned this Apr 11, 2024
@kennethshsu
Copy link
Collaborator

@jbogaardt did you resolve this?

@kennethshsu kennethshsu mentioned this issue Apr 24, 2024
@jbogaardt
Copy link
Collaborator Author

I have not, but it probably makes the most sense to explicitly set date formats of datasets within the package to silence it for training purposes, but otherwise persist the deprecation.

@kennethshsu
Copy link
Collaborator

Hmm, can you elaborate more on what you mean?

There's a PR on what I think fixes the issue, it's just using the version package to check for versions.

jbogaardt pushed a commit that referenced this issue May 1, 2024
* Debugging

* Addressed tine A-DEC vs Y-DEC

* Undoing the change

* Removed debugger

* Reversed the Y and A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants