Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed #420 and #491 #507

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Addressed #420 and #491 #507

merged 7 commits into from
Apr 5, 2024

Conversation

kennethshsu
Copy link
Collaborator

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.62%. Comparing base (583760a) to head (b88308d).

Files Patch % Lines
chainladder/core/display.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   80.57%   80.62%   +0.05%     
==========================================
  Files          80       80              
  Lines        4735     4739       +4     
  Branches      808      808              
==========================================
+ Hits         3815     3821       +6     
+ Misses        643      642       -1     
+ Partials      277      276       -1     
Flag Coverage Δ
unittests 80.62% <40.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbogaardt jbogaardt merged commit 38e6760 into master Apr 5, 2024
7 of 8 checks passed
@jbogaardt
Copy link
Collaborator

I'm surprised we have polars in the dev environment. I've been experimenting with it in lieu of sparse, but haven't hit a point where it should be in the main branch.

@kennethshsu kennethshsu deleted the #420_new branch April 5, 2024 17:18
@kennethshsu
Copy link
Collaborator Author

polars was already there I think, I only added the newer cpu version of it.

From the very limited few hours that I spent messing with it, I like it a lot and prefer it over sparse too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants