Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Complete the implementation of the latest APIs. #63

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

AsakusaRinne
Copy link
Contributor

Sync with the latest APIs of Casbin.NET 2.x.

@hsluoyz hsluoyz requested a review from sagilio August 20, 2022 13:23
@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2022

@sagilio plz review

@sagilio sagilio self-assigned this Aug 20, 2022
@sagilio sagilio added the enhancement New feature or request label Aug 20, 2022
Copy link
Member

@sagilio sagilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most LGTM

Casbin.Adapter.EFCore/Extensions/CasbinRuleExtenstion.cs Outdated Show resolved Hide resolved
Casbin.Adapter.EFCore/Extensions/CasbinRuleExtenstion.cs Outdated Show resolved Hide resolved
Casbin.Adapter.EFCore/EFCoreAdapter.cs Outdated Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Aug 21, 2022

@sagilio

Copy link
Member

@sagilio sagilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagilio
Copy link
Member

sagilio commented Aug 22, 2022

@AsakusaRinne plz sign off the commits
image

@AsakusaRinne
Copy link
Contributor Author

@AsakusaRinne plz sign off the commits image

OK, done.

@hsluoyz hsluoyz merged commit e9625de into casbin-net:preview Aug 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.9.0-preview.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0-preview.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants