Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies on crates.io #31

Closed
0xethsign opened this issue May 5, 2021 · 5 comments · Fixed by #33
Closed

Update dependencies on crates.io #31

0xethsign opened this issue May 5, 2021 · 5 comments · Fixed by #33
Assignees
Labels
enhancement New feature or request

Comments

@0xethsign
Copy link
Member

actix-casbin-auth uses tokio 1.5.0, but the webpage on crates.io shows 0.2. -
Screenshot from 2021-05-05 07-12-18
Also few other dependencies like actix-rt also need to updated. Can this be manually done?

@PsiACE
Copy link
Contributor

PsiACE commented May 5, 2021

This should be caused by actix-web , there is no good way for the time being

@0xethsign
Copy link
Member Author

actix-casbin-auth uses actix-web 4.0.0-beta.6. The code is working fine.
I had to use actix-casbin-auth = { git = "https://github.com/casbin-rs/actix-casbin-auth", branch = "master" } in the Cargo.toml of actix-casbin, because the tests were failing when downloaded from crates.io. Can this be used? (I'm asking if this is allowed as per the coding standards)

@PsiACE
Copy link
Contributor

PsiACE commented May 5, 2021

Of course. But if you use github directly, you will be temporarily unable to release a new version to crates.io. It may require you to pay more attention to maintenance.

@hsluoyz hsluoyz self-assigned this May 5, 2021
@hsluoyz hsluoyz added the question Further information is requested label May 5, 2021
@hsluoyz
Copy link
Member

hsluoyz commented May 29, 2021

@hackerchai

@thespooler
Copy link
Contributor

Should be resolved by #33. actix-web 4.0 depends on actix-rt 2.7, that depends on tokio 1.13.

@hsluoyz hsluoyz added enhancement New feature or request and removed question Further information is requested labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants