Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for actix-web 4.0.1 #33

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix for actix-web 4.0.1 #33

merged 1 commit into from
Mar 21, 2022

Conversation

thespooler
Copy link
Contributor

@thespooler thespooler commented Mar 20, 2022

Fix: #27

Fix: #31

@casbin-bot
Copy link

@smrpn @hackerchai @PsiACE @GopherJ please review

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #33 (b371571) into master (1a79901) will decrease coverage by 1.25%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   81.11%   79.86%   -1.26%     
==========================================
  Files           4        4              
  Lines         143      149       +6     
==========================================
+ Hits          116      119       +3     
- Misses         27       30       +3     
Impacted Files Coverage Δ
tests/test_middleware.rs 93.54% <ø> (+0.21%) ⬆️
tests/test_set_enforcer.rs 93.75% <ø> (+0.20%) ⬆️
src/middleware.rs 57.89% <35.71%> (-3.22%) ⬇️
tests/test_middleware_domain.rs 93.10% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a79901...b371571. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 21, 2022

@PsiACE

Copy link
Member

@hackerchai hackerchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PsiACE PsiACE merged commit 05a4a26 into casbin-rs:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies on crates.io Bump actix-web to 4.0
7 participants