Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #26

Merged
merged 5 commits into from
Mar 7, 2021
Merged

Update README #26

merged 5 commits into from
Mar 7, 2021

Conversation

0xethsign
Copy link
Member

@0xethsign 0xethsign commented Mar 6, 2021

This will avoid async runtime multiple importing issues.

Fix: #25

@hsluoyz hsluoyz requested a review from hackerchai March 6, 2021 12:19
@hsluoyz
Copy link
Member

hsluoyz commented Mar 6, 2021

@hackerchai please review. Also can you help see why the CI failed?

image

@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #26 (db51640) into master (d381180) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   80.71%   81.11%   +0.40%     
==========================================
  Files           4        4              
  Lines         140      143       +3     
==========================================
+ Hits          113      116       +3     
  Misses         27       27              
Impacted Files Coverage Δ
tests/test_set_enforcer.rs 93.54% <0.00%> (+0.21%) ⬆️
tests/test_middleware.rs 93.33% <0.00%> (+0.22%) ⬆️
tests/test_middleware_domain.rs 92.85% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d381180...db51640. Read the comment docs.

@0xethsign
Copy link
Member Author

I think this works now.

Copy link
Member

@hackerchai hackerchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hackerchai hackerchai merged commit 4526bfc into casbin-rs:master Mar 7, 2021
@0xethsign
Copy link
Member Author

I think #25 can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: could not compile casbin; the name ... is defined multiple times
4 participants