Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support build Incremental role links #118

Merged
merged 1 commit into from
Feb 7, 2021
Merged

feat: Support build Incremental role links #118

merged 1 commit into from
Feb 7, 2021

Conversation

sagilio
Copy link
Member

@sagilio sagilio commented Jan 30, 2021 •
edited by hsluoyz
Loading

Fix: #82

@sagilio sagilio added enhancement Enhancement the exist feature new feature New feature will be provided or request labels Jan 30, 2021
@sagilio sagilio self-assigned this Jan 30, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Feb 1, 2021

@xcaptain plz review.

xcaptain
xcaptain suggested changes Feb 4, 2021
View reviewed changes
Copy link

@xcaptain xcaptain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if autoBuildRoleLinks was set false, some tests would fail

NetCasbin/InternalEnforcer.cs Outdated Show resolved Hide resolved
NetCasbin/InternalEnforcer.cs Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Feb 4, 2021

@sagilio

@sagilio sagilio force-pushed the fix#82 branch 2 times, most recently from 05a0e04 to 75dfedf Compare February 4, 2021 12:49
@sagilio sagilio requested a review from xcaptain February 4, 2021 13:59
@hsluoyz
Copy link
Member

hsluoyz commented Feb 7, 2021

@sagilio plz fix semantic-PR:

image

@sagilio sagilio changed the title Support build Incremental role links feat: Support build Incremental role links Feb 7, 2021
@sagilio
feat: Support build Incremental role links
bfa8b64 
Signed-off-by: Sagilio <Sagilio@outlook.com>
@sagilio
Copy link
Member Author

sagilio commented Feb 7, 2021

@sagilio plz fix semantic-PR:

image

Fixed.

@hsluoyz hsluoyz merged commit cefb330 into casbin:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcaptain xcaptain xcaptain approved these changes

@huazhikui huazhikui Awaiting requested review from huazhikui

Assignees

@sagilio sagilio

Labels
enhancement Enhancement the exist feature new feature New feature will be provided or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support build Incremental role links
3 participants
@sagilio @hsluoyz @xcaptain