Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Setup Sonarcloud Analysis #223

Merged
merged 2 commits into from Nov 16, 2021
Merged

Conversation

Leonardo-Ferreira
Copy link
Member

@Leonardo-Ferreira Leonardo-Ferreira commented Nov 15, 2021

Fix: #220

Created the sonar.yml, which builds, tests and analyses the solution using sonarcloud.

The reports will be accessible at https://sonarcloud.io/organizations/casbin/projects

A preview of the result can be seen here: https://sonarcloud.io/organizations/leonardo-ferreira/projects

Signed-off-by: Leonardo Ferreira <index.xp@gmail.com>
@casbin-bot
Copy link
Member

@sagilio @xcaptain @huazhikui please review

Signed-off-by: Leonardo Ferreira <index.xp@gmail.com>
@hsluoyz
Copy link
Member

hsluoyz commented Nov 16, 2021

@Leonardo-Ferreira is there some kind of badge for it? Can you add it also in README in this PR?

@hsluoyz
Copy link
Member

hsluoyz commented Nov 16, 2021

@Leonardo-Ferreira plz fix:

image

@hsluoyz
Copy link
Member

hsluoyz commented Nov 16, 2021

@sagilio plz reivew

@Leonardo-Ferreira
Copy link
Member Author

Leonardo-Ferreira commented Nov 16, 2021

@Leonardo-Ferreira plz fix:

image

The error there is a "blank" secret and I actually can't fix it because the PR is not allowed to read GitHub secrets! once it's merged, it will. My repo has sech secrets and you can see at the bottom of https://sonarcloud.io/project/overview?id=Leonardo-Ferreira_Casbin.NET that the commit that triggered the analysis is this last one here:
image

@Leonardo-Ferreira
Copy link
Member Author

@Leonardo-Ferreira is there some kind of badge for it? Can you add it also in README in this PR?

There is and I can, but I rather not do it right now because we have not defined the quality gates for the repo (which can be done only after the first analysis and computed after the at least the second). Not doing so might display an incorrect "red/failed" badge. I'd rather define these gates with you guys as a second activity which would culminate with the badge and the updated README. What you think?

@hsluoyz
Copy link
Member

hsluoyz commented Nov 16, 2021

OK

@hsluoyz hsluoyz merged commit 3c91830 into casbin:master Nov 16, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor with sonar cloud?
3 participants