Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add new unit tests for management APIs #265

Merged
merged 1 commit into from Jul 3, 2022

Conversation

sociometry
Copy link
Contributor

Test: Add new unittests to ManagementApi referring to Go version.

Signed-off-by: sociometry <aiyouwangle@163.com>
@casbin-bot
Copy link
Member

@sagilio @xcaptain @huazhikui please review

@hsluoyz
Copy link
Member

hsluoyz commented Jun 19, 2022

@sociometry we normally don't recommend WIP PR to be proposed, as it usually wasted watchers' attention.

@sagilio sagilio self-assigned this Jun 19, 2022
@sagilio sagilio added the enhancement Enhancement the exist feature label Jun 19, 2022
@sociometry sociometry marked this pull request as ready for review June 19, 2022 13:46
@sagilio sagilio changed the title test: add new unittests to ManagementApi referring to Go version test: Add new unit tests to management API referring to Go version Jun 19, 2022
@sagilio sagilio changed the title test: Add new unit tests to management API referring to Go version test: Add new unit tests for management APIs Jun 19, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Jun 22, 2022

@sagilio plz review

Copy link
Member

@sagilio sagilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagilio sagilio merged commit 5c38d7e into casbin:preview Jul 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 2.0.0-preview.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants