feat: fix null value handling logic #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagilio please review |
|
|
…ge the logical of ValidatePolicy
hsluoyz
changed the title
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
sagilio0728
pushed a commit
to sagilio0728/Casbin.NET
that referenced
this pull request
Apr 21, 2024
This reverts commit 54db948.
hsluoyz
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Revert "fix: fix bugs in policy equal and persist (#347)" This reverts commit 3306375. * Revert "feat: fix null value handling logic (#337)" This reverts commit 54db948. * feat: compatible with unexpected policy Signed-off-by: sagilio <sagilio@outlook.com> --------- Signed-off-by: sagilio <sagilio@outlook.com> Co-authored-by: sagilio <sagilio@outlook.com>
sagilio0728
added a commit
to sagilio0728/Casbin.NET
that referenced
this pull request
Apr 22, 2024
…asbin#350) Signed-off-by: sagilio <sagilio0728@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the way to judge if a string is null , but i'm not sure will it cause other bug
this pr may be a temporary solution for issue #335
it will be better to rewire class Policy
Fix: #335