Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup benchmarks #42

Closed
GopherJ opened this issue Jun 21, 2020 · 8 comments · Fixed by #114, #116 or #118
Closed

Setup benchmarks #42

GopherJ opened this issue Jun 21, 2020 · 8 comments · Fixed by #114, #116 or #118
Assignees
@GopherJ
Labels
enhancement New feature or request released

Comments

@GopherJ
Copy link
Member

GopherJ commented Jun 21, 2020 •
edited
Loading

Really happy to see a new casbin product is born with good features, thanks @divy9881 for your hard work.

BTW, It's also interesting to see benchmarks numbers in casbin-cpp, normally cpp should win bench again rust and golang.

Could you add benchmarks?
@hsluoyz
Copy link
Member

hsluoyz commented Jun 21, 2020

Sounds good. We can compare C++ with Rust.

@hsluoyz hsluoyz added enhancement New feature or request help wanted Extra attention is needed labels Jun 21, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Jun 21, 2020

@divy9881 @ZipoChan

@EmperorYP7
Copy link
Member

We may use custom benchmarking by making utility classes, or we may go for Google’s benchmark tool.

What kind of benchmarking is desired? Are we into visual benchmarking as well?

@hsluoyz hsluoyz removed the help wanted Extra attention is needed label Apr 7, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Apr 7, 2021

@EmperorYP7 we want a cross-platform (Win, Linux, macOS), easy-to-use, modern and similar-to-Go benchmark solution, is there such a solution?

@EmperorYP7
Copy link
Member

@hsluoyz I looked over the benchmarking implemented in casbin.
Google's benchmark would be perfect for this. It's cross-platform and quite similar to Go's benchmarking. May I take this up?

@hsluoyz
Copy link
Member

hsluoyz commented Apr 7, 2021

OK!

@EmperorYP7 EmperorYP7 mentioned this issue May 21, 2021
Closed
@EmperorYP7 EmperorYP7 mentioned this issue Jun 28, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Jul 3, 2021
Merged
Merged
@hsluoyz hsluoyz removed this from Casbin-CPP Easy Tasks in Casbin Easy Tasks for Beginners/Student Applicants Jul 5, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GopherJ GopherJ

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
3 participants
@hsluoyz @GopherJ @EmperorYP7