Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Benchmarks for ManagementAPI #118

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

EmperorYP7
Copy link
Member

@EmperorYP7 EmperorYP7 commented Jul 4, 2021

Fixes #42

Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in

Description

This code adds benchmarks for ManagementAPI. This includes:

  • Enforcer::HasPolicy()
  • Enforcer::AddPolicy()
  • Enforcer::RemovePolicy()

for small, medium, and large workflows.

Note: This should be merged only after #116 is merged into master.

Issues detected

The large workflow benchmarks show that the management API functions are dramatically slower than that of GoLang.

Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@hsluoyz hsluoyz requested a review from xcaptain July 5, 2021 16:20
@hsluoyz
Copy link
Member

hsluoyz commented Jul 5, 2021

@xcaptain

@EmperorYP7
Copy link
Member Author

@hsluoyz @xcaptain Benchmarks with large datasets are bottlenecking the execution thread.

Screenshot 2021-07-13 at 4 01 35 PM

@hsluoyz hsluoyz merged commit dbb4d24 into casbin:master Jul 13, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Jul 13, 2021

@EmperorYP7 you can add the C++ result to our benchmark page (between Go and Lua tabs): https://casbin.org/docs/en/benchmark

@github-actions
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@EmperorYP7
Copy link
Member Author

EmperorYP7 commented Jul 16, 2021

@EmperorYP7 you can add the C++ result to our benchmark page (between Go and Lua tabs):

@hsluoyz On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup benchmarks
2 participants