Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Management API, Utility methods and more #108

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

EmperorYP7
Copy link
Member

@EmperorYP7 EmperorYP7 commented Jun 18, 2021

Fixes #41 partially

Signed-off-by: Yash Pandey(YP) yash.btech.cs19@iiitranchi.ac.in


Description

This code adds tests for:

  • Management API
  • Utility functions/methods
  • casbin's Config API
  • Build-in functions

Points to note

  • Tests for casbin::SyncedEnforcer are commented out. This is because GTest isn't made for testing multithreaded workloads. I tried multiple workarounds, but it doesn't seem to work out.

@EmperorYP7 EmperorYP7 marked this pull request as draft June 18, 2021 22:12
@EmperorYP7 EmperorYP7 force-pushed the ctest-full branch 2 times, most recently from 9f12925 to 09248ef Compare June 24, 2021 14:26
@EmperorYP7 EmperorYP7 marked this pull request as ready for review June 24, 2021 14:27
@EmperorYP7
Copy link
Member Author

@hsluoyz @xcaptain @divy9881
Kindly have a look.

@hsluoyz hsluoyz requested a review from xcaptain June 25, 2021 00:44
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@EmperorYP7
Copy link
Member Author

EmperorYP7 commented Jun 28, 2021

@hsluoyz @xcaptain May we merge this? The code only contains some tests that were already implemented in MS Unit tests.

Note: Azure test is intended to fail as it is fixed in #109 by removing MS Tests altogether.

@xcaptain
Copy link

Sorry for the late reply, it's ok for me, let's merge it

@EmperorYP7
Copy link
Member Author

@hsluoyz I think this is ready to be merged now.

@hsluoyz hsluoyz merged commit 5fc6caa into casbin:master Jun 29, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup code coverage badge
3 participants