feat: Streamlined types #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
|
@xcaptain plz review |
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in
Description
This code adds type definitions for accomodating
casbin::ABACDatawithin the entirety of the project.The definitions are as follows:
AttributeValue: The type of a value of an attributeAttribute: The type of an attribute containing the name and the value as astd::pair.AttributeVector: Vector of attributes.AttributeList: Initializer list of attributes.AttributeMap: Unordered map containing name and value of the attributes.Data: Type of Data for accomodatingABACDataDataVector: Vector ofcasbin::DataDataList: Initializer list ofcasbin::DataDataMap: unordered map containing the name andcasbin::DataNoteworthy
The code introduces intrinsic type definitions to casbin. This might affect the overall user-friendliness of the project. However, the type names added here are intuitive and easy to understand, even for a first-time user.