Two apis of github oauth changed which cause login failed #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue:
1. Api "https://api.github.com/user/emails" 不再支持 query params 方式追加 access_token参数;
2. Api "https://api.github.com/user" 不再支持 query params 方式追加 access_token参数;
Resolve:
以上两接口均按 [github 文档-user](https://docs.github.com/en/free-pro-team@latest/rest/reference/users#list-email-addresses-for-the-authenticated-user)改为 在 header 中 添加
- ("Authorization", "token " + access_token);
- ("access", "application/vnd.github.v3+json");
得以解决。
|
@tufatao hi, can you modify the PR title and text into English? |
tufatao
changed the title
tufatao
changed the title
tufatao
changed the title
|
@tufatao why closed? |
tufatao
changed the title
|
lgtm |
|
@tufatao thanks for contributing to Casbin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : [issue-number]
Description :
Resolve:
I modified the function "AuthGithub" in account.go according to the github rest api.
1. put the parameter "Authorization" with the value of "access_token" in header instead of in query;
2. add the parameter "access" with the recommended value "application/vnd.github.v3+json" in header;
Screenshot of changes :
Please ensure Checkmark the following :