Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two apis of github oauth changed which cause login failed #139

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Two apis of github oauth changed which cause login failed #139

merged 1 commit into from
Dec 16, 2020

Commits on Dec 8, 2020

  1. Title: 解决因 github oauth 相关接口变更导致登录失败的问题 

    Issue:
    1. Api "https://api.github.com/user/emails" 不再支持 query params 方式追加 access_token参数;
    2. Api "https://api.github.com/user" 不再支持 query params 方式追加 access_token参数;

Resolve:
    以上两接口均按 [github 文档-user](https://docs.github.com/en/free-pro-team@latest/rest/reference/users#list-email-addresses-for-the-authenticated-user)改为 在 header 中 添加
      - ("Authorization", "token " + access_token);
      - ("access", "application/vnd.github.v3+json");
    得以解决。
    @tufatao
    tufatao committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    ac16917 View commit details
    Browse the repository at this point in the history