Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate TLS config #36

Open
Tracked by #41
nodece opened this issue Nov 4, 2021 · 2 comments
Open
Tracked by #41

Separate TLS config #36

nodece opened this issue Nov 4, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nodece
Copy link
Member

nodece commented Nov 4, 2021

Motivaction

Currently, we just have one TLS config, which is used for Raft and HTTP/GRPC servers, it is unsafe. When a client uses this TLS config, it can access the Raft and HTTP/GRPC servers, we cannot allow the client to access the Raft server, it is dangerous, so we need to split two TLS configs for HTTP/GPRC servers and Raft servers.

Improvement Way

Support setting the TLS for HTTP/GPRC and Raft servers respectively.

  • HTTP/GRPC server TLS config, it is used to client-to-server communication, so like:
--endpoint-ca-file <path>
--endpoint-cert-file <path>
--endpoint-key-file <path>
  • Raft server TLS config, it is used to server-to-server communication, so like:
--peer-ca-file <path>
--peer-cert-file <path>
--peer-key-file <path>
@casbin-bot
Copy link
Member

@WenyXu @nodece

@casbin-bot casbin-bot added the question Further information is requested label Nov 5, 2021
@nodece nodece added enhancement New feature or request and removed question Further information is requested labels Nov 6, 2021
@WenyXu WenyXu mentioned this issue May 12, 2022
13 tasks
@AbdelrahmanElawady
Copy link
Contributor

hello I am working on this issue, and looking through the code i think Raft connection is using only the ca file and not using cert file and key file, also for the endpoint only cert and key files are used but ca isn't, so is there a point for adding the unused flags too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants