Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrade async-std to 1.6 beta #136

Closed
wants to merge 20 commits into from

Conversation

GopherJ
Copy link
Member

@GopherJ GopherJ commented May 8, 2020

No description provided.

@GopherJ GopherJ changed the title upgrade async-std to 1.6 beta WIP: upgrade async-std to 1.6 beta May 8, 2020
@GopherJ
Copy link
Member Author

GopherJ commented May 8, 2020

wait to solve: async-rs/async-std#766

@dignifiedquire
Copy link

I just checked and this passes all tests when including async-rs/async-std#768

@GopherJ
Copy link
Member Author

GopherJ commented May 9, 2020

@dignifiedquire Thanks, I'll wait for it to be merged then!

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #136 into master will decrease coverage by 4.04%.
The diff coverage is 61.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   85.75%   81.71%   -4.05%     
==========================================
  Files          19       20       +1     
  Lines        3025     3111      +86     
==========================================
- Hits         2594     2542      -52     
- Misses        431      569     +138     
Impacted Files Coverage Δ
src/cache/default_cache.rs 0.00% <0.00%> (-93.34%) ⬇️
src/cached_enforcer.rs 0.00% <0.00%> (-5.69%) ⬇️
src/emitter.rs 0.00% <0.00%> (-66.67%) ⬇️
src/error.rs 100.00% <ø> (ø)
src/logger/default_logger.rs 0.00% <0.00%> (ø)
src/model/function_map.rs 94.64% <0.00%> (-2.20%) ⬇️
src/util.rs 97.77% <0.00%> (ø)
src/internal_api.rs 31.00% <16.32%> (-16.06%) ⬇️
src/convert.rs 40.00% <33.33%> (-10.00%) ⬇️
src/enforcer.rs 85.38% <74.10%> (-5.24%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1824313...f016809. Read the comment docs.

@GopherJ GopherJ mentioned this pull request May 9, 2020
@GopherJ
Copy link
Member Author

GopherJ commented May 10, 2020

closed in favor of #137 , the only difference between #137 and #136 should be async-std, we'll need to wait async-std to have a stable version of 1.6.0 and we also need to find a correct way for writting benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants