Skip to content

Commit

Permalink
fix: LoadPolicyFast perm not work #1332
Browse files Browse the repository at this point in the history
  • Loading branch information
@rentiansheng
rentiansheng committed Oct 20, 2023
1 parent 0ee4a9b commit f5263f1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions enforcer_synced.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ func (e *SyncedEnforcer) LoadPolicyFast() error {
// reduce the lock range
e.m.Lock()
defer e.m.Unlock()
e.invalidateMatcherMap()
e.model = newModel
e.rmMap = newRmMap
return nil
Expand Down

1 comment on commit f5263f1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f5263f1 Previous: c907b90 Ratio
BenchmarkCachedRaw - ns/op 20.61 ns/op 20.63 ns/op 1.00
BenchmarkCachedRaw - B/op 0 B/op 0 B/op NaN
BenchmarkCachedRaw - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkCachedBasicModel - ns/op 236 ns/op 227.4 ns/op 1.04
BenchmarkCachedBasicModel - B/op 104 B/op 104 B/op 1
BenchmarkCachedBasicModel - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModel - ns/op 230 ns/op 228.7 ns/op 1.01
BenchmarkCachedRBACModel - B/op 104 B/op 104 B/op 1
BenchmarkCachedRBACModel - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModelSmall - ns/op 236.3 ns/op 234.8 ns/op 1.01
BenchmarkCachedRBACModelSmall - B/op 104 B/op 104 B/op 1
BenchmarkCachedRBACModelSmall - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModelMedium - ns/op 243.7 ns/op 254.7 ns/op 0.96
BenchmarkCachedRBACModelMedium - B/op 104 B/op 104 B/op 1
BenchmarkCachedRBACModelMedium - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModelLarge - ns/op 228.6 ns/op 219.1 ns/op 1.04
BenchmarkCachedRBACModelLarge - B/op 96 B/op 96 B/op 1
BenchmarkCachedRBACModelLarge - allocs/op 3 allocs/op 3 allocs/op 1
BenchmarkCachedRBACModelWithResourceRoles - ns/op 237.3 ns/op 228.8 ns/op 1.04
BenchmarkCachedRBACModelWithResourceRoles - B/op 104 B/op 104 B/op 1
BenchmarkCachedRBACModelWithResourceRoles - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModelWithDomains - ns/op 249.8 ns/op 245 ns/op 1.02
BenchmarkCachedRBACModelWithDomains - B/op 120 B/op 120 B/op 1
BenchmarkCachedRBACModelWithDomains - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedABACModel - ns/op 3699 ns/op 3578 ns/op 1.03
BenchmarkCachedABACModel - B/op 1524 B/op 1522 B/op 1.00
BenchmarkCachedABACModel - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkCachedKeyMatchModel - ns/op 256.4 ns/op 246 ns/op 1.04
BenchmarkCachedKeyMatchModel - B/op 152 B/op 152 B/op 1
BenchmarkCachedKeyMatchModel - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedRBACModelWithDeny - ns/op 234.1 ns/op 227.7 ns/op 1.03
BenchmarkCachedRBACModelWithDeny - B/op 104 B/op 104 B/op 1
BenchmarkCachedRBACModelWithDeny - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedPriorityModel - ns/op 233.8 ns/op 240.7 ns/op 0.97
BenchmarkCachedPriorityModel - B/op 104 B/op 104 B/op 1
BenchmarkCachedPriorityModel - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkCachedWithEnforceContext - ns/op 441.3 ns/op 432 ns/op 1.02
BenchmarkCachedWithEnforceContext - B/op 240 B/op 240 B/op 1
BenchmarkCachedWithEnforceContext - allocs/op 5 allocs/op 5 allocs/op 1
BenchmarkCachedRBACModelMediumParallel - ns/op 228.7 ns/op 235.2 ns/op 0.97
BenchmarkCachedRBACModelMediumParallel - B/op 105 B/op 105 B/op 1
BenchmarkCachedRBACModelMediumParallel - allocs/op 4 allocs/op 4 allocs/op 1
BenchmarkHasPolicySmall - ns/op 692.7 ns/op 680.6 ns/op 1.02
BenchmarkHasPolicySmall - B/op 150 B/op 150 B/op 1
BenchmarkHasPolicySmall - allocs/op 6 allocs/op 6 allocs/op 1
BenchmarkHasPolicyMedium - ns/op 741.3 ns/op 747.2 ns/op 0.99
BenchmarkHasPolicyMedium - B/op 157 B/op 157 B/op 1
BenchmarkHasPolicyMedium - allocs/op 6 allocs/op 6 allocs/op 1
BenchmarkHasPolicyLarge - ns/op 786.1 ns/op 758.8 ns/op 1.04
BenchmarkHasPolicyLarge - B/op 165 B/op 165 B/op 1
BenchmarkHasPolicyLarge - allocs/op 7 allocs/op 7 allocs/op 1
BenchmarkAddPolicySmall - ns/op 725.6 ns/op 720.8 ns/op 1.01
BenchmarkAddPolicySmall - B/op 152 B/op 152 B/op 1
BenchmarkAddPolicySmall - allocs/op 6 allocs/op 6 allocs/op 1
BenchmarkAddPolicyMedium - ns/op 1022 ns/op 957.6 ns/op 1.07
BenchmarkAddPolicyMedium - B/op 182 B/op 180 B/op 1.01
BenchmarkAddPolicyMedium - allocs/op 7 allocs/op 7 allocs/op 1
BenchmarkAddPolicyLarge - ns/op 1619 ns/op 1700 ns/op 0.95
BenchmarkAddPolicyLarge - B/op 413 B/op 463 B/op 0.89
BenchmarkAddPolicyLarge - allocs/op 9 allocs/op 9 allocs/op 1
BenchmarkRemovePolicySmall - ns/op 729 ns/op 720.7 ns/op 1.01
BenchmarkRemovePolicySmall - B/op 166 B/op 166 B/op 1
BenchmarkRemovePolicySmall - allocs/op 7 allocs/op 7 allocs/op 1
BenchmarkRemovePolicyMedium - ns/op 823.7 ns/op 812 ns/op 1.01
BenchmarkRemovePolicyMedium - B/op 178 B/op 178 B/op 1
BenchmarkRemovePolicyMedium - allocs/op 7 allocs/op 7 allocs/op 1
BenchmarkRemovePolicyLarge - ns/op 1733 ns/op 1670 ns/op 1.04
BenchmarkRemovePolicyLarge - B/op 293 B/op 293 B/op 1
BenchmarkRemovePolicyLarge - allocs/op 13 allocs/op 13 allocs/op 1
BenchmarkRaw - ns/op 20.65 ns/op 20.59 ns/op 1.00
BenchmarkRaw - B/op 0 B/op 0 B/op NaN
BenchmarkRaw - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkBasicModel - ns/op 4691 ns/op 4603 ns/op 1.02
BenchmarkBasicModel - B/op 1492 B/op 1488 B/op 1.00
BenchmarkBasicModel - allocs/op 17 allocs/op 17 allocs/op 1
BenchmarkRBACModel - ns/op 7142 ns/op 7097 ns/op 1.01
BenchmarkRBACModel - B/op 2039 B/op 2033 B/op 1.00
BenchmarkRBACModel - allocs/op 35 allocs/op 35 allocs/op 1
BenchmarkRBACModelSizes/small - ns/op 65963 ns/op 63713 ns/op 1.04
BenchmarkRBACModelSizes/small - B/op 20008 B/op 19961 B/op 1.00
BenchmarkRBACModelSizes/small - allocs/op 480 allocs/op 480 allocs/op 1
BenchmarkRBACModelSizes/medium - ns/op 761965 ns/op 723241 ns/op 1.05
BenchmarkRBACModelSizes/medium - B/op 191280 B/op 191292 B/op 1.00
BenchmarkRBACModelSizes/medium - allocs/op 4827 allocs/op 4829 allocs/op 1.00
BenchmarkRBACModelSizes/large - ns/op 8783663 ns/op 8190155 ns/op 1.07
BenchmarkRBACModelSizes/large - B/op 1895352 B/op 1899289 B/op 1.00
BenchmarkRBACModelSizes/large - allocs/op 48057 allocs/op 48168 allocs/op 1.00
BenchmarkRBACModelSmall - ns/op 78067 ns/op 78583 ns/op 0.99
BenchmarkRBACModelSmall - B/op 20074 B/op 20024 B/op 1.00
BenchmarkRBACModelSmall - allocs/op 615 allocs/op 615 allocs/op 1
BenchmarkRBACModelMedium - ns/op 754597 ns/op 759773 ns/op 0.99
BenchmarkRBACModelMedium - B/op 194370 B/op 194076 B/op 1.00
BenchmarkRBACModelMedium - allocs/op 6022 allocs/op 6022 allocs/op 1
BenchmarkRBACModelLarge - ns/op 9468711 ns/op 8955833 ns/op 1.06
BenchmarkRBACModelLarge - B/op 1947855 B/op 1948375 B/op 1.00
BenchmarkRBACModelLarge - allocs/op 60927 allocs/op 60935 allocs/op 1.00
BenchmarkRBACModelWithResourceRoles - ns/op 5865 ns/op 5745 ns/op 1.02
BenchmarkRBACModelWithResourceRoles - B/op 1824 B/op 1820 B/op 1.00
BenchmarkRBACModelWithResourceRoles - allocs/op 27 allocs/op 27 allocs/op 1
BenchmarkRBACModelWithDomains - ns/op 6466 ns/op 6503 ns/op 0.99
BenchmarkRBACModelWithDomains - B/op 1806 B/op 1803 B/op 1.00
BenchmarkRBACModelWithDomains - allocs/op 25 allocs/op 25 allocs/op 1
BenchmarkABACModel - ns/op 3610 ns/op 3587 ns/op 1.01
BenchmarkABACModel - B/op 1516 B/op 1511 B/op 1.00
BenchmarkABACModel - allocs/op 17 allocs/op 17 allocs/op 1
BenchmarkABACRuleModel - ns/op 4984415 ns/op 4886698 ns/op 1.02
BenchmarkABACRuleModel - B/op 1307380 B/op 1302457 B/op 1.00
BenchmarkABACRuleModel - allocs/op 40089 allocs/op 40088 allocs/op 1.00
BenchmarkKeyMatchModel - ns/op 7788 ns/op 7729 ns/op 1.01
BenchmarkKeyMatchModel - B/op 3028 B/op 3018 B/op 1.00
BenchmarkKeyMatchModel - allocs/op 37 allocs/op 37 allocs/op 1
BenchmarkRBACModelWithDeny - ns/op 9205 ns/op 9174 ns/op 1.00
BenchmarkRBACModelWithDeny - B/op 2450 B/op 2443 B/op 1.00
BenchmarkRBACModelWithDeny - allocs/op 49 allocs/op 49 allocs/op 1
BenchmarkPriorityModel - ns/op 5375 ns/op 5294 ns/op 1.02
BenchmarkPriorityModel - B/op 1742 B/op 1737 B/op 1.00
BenchmarkPriorityModel - allocs/op 22 allocs/op 22 allocs/op 1
BenchmarkRBACModelWithDomainPatternLarge - ns/op 29868 ns/op 29392 ns/op 1.02
BenchmarkRBACModelWithDomainPatternLarge - B/op 16605 B/op 16600 B/op 1.00
BenchmarkRBACModelWithDomainPatternLarge - allocs/op 164 allocs/op 164 allocs/op 1
BenchmarkRoleManagerSmall - ns/op 101606 ns/op 99155 ns/op 1.02
BenchmarkRoleManagerSmall - B/op 11953 B/op 11952 B/op 1.00
BenchmarkRoleManagerSmall - allocs/op 797 allocs/op 797 allocs/op 1
BenchmarkRoleManagerMedium - ns/op 1050129 ns/op 1036586 ns/op 1.01
BenchmarkRoleManagerMedium - B/op 125908 B/op 125908 B/op 1
BenchmarkRoleManagerMedium - allocs/op 8741 allocs/op 8741 allocs/op 1
BenchmarkRoleManagerLarge - ns/op 13132005 ns/op 12397943 ns/op 1.06
BenchmarkRoleManagerLarge - B/op 1349916 B/op 1349918 B/op 1.00
BenchmarkRoleManagerLarge - allocs/op 89741 allocs/op 89741 allocs/op 1
BenchmarkBuildRoleLinksWithPatternLarge - ns/op 8210023263 ns/op 7785706663 ns/op 1.05
BenchmarkBuildRoleLinksWithPatternLarge - B/op 5296181320 B/op 5285519344 B/op 1.00
BenchmarkBuildRoleLinksWithPatternLarge - allocs/op 60938666 allocs/op 60936186 allocs/op 1.00
BenchmarkBuildRoleLinksWithDomainPatternLarge - ns/op 221493021 ns/op 212630286 ns/op 1.04
BenchmarkBuildRoleLinksWithDomainPatternLarge - B/op 140051603 B/op 139762052 B/op 1.00
BenchmarkBuildRoleLinksWithDomainPatternLarge - allocs/op 1676234 allocs/op 1676177 allocs/op 1.00
BenchmarkBuildRoleLinksWithPatternAndDomainPatternLarge - ns/op 8237158501 ns/op 7953300670 ns/op 1.04
BenchmarkBuildRoleLinksWithPatternAndDomainPatternLarge - B/op 5433490448 B/op 5422141896 B/op 1.00
BenchmarkBuildRoleLinksWithPatternAndDomainPatternLarge - allocs/op 62549225 allocs/op 62546523 allocs/op 1.00
BenchmarkHasLinkWithPatternLarge - ns/op 13464 ns/op 13547 ns/op 0.99
BenchmarkHasLinkWithPatternLarge - B/op 7551 B/op 7537 B/op 1.00
BenchmarkHasLinkWithPatternLarge - allocs/op 111 allocs/op 111 allocs/op 1
BenchmarkHasLinkWithDomainPatternLarge - ns/op 726 ns/op 720.9 ns/op 1.01
BenchmarkHasLinkWithDomainPatternLarge - B/op 80 B/op 80 B/op 1
BenchmarkHasLinkWithDomainPatternLarge - allocs/op 5 allocs/op 5 allocs/op 1
BenchmarkHasLinkWithPatternAndDomainPatternLarge - ns/op 14570 ns/op 13273 ns/op 1.10
BenchmarkHasLinkWithPatternAndDomainPatternLarge - B/op 7552 B/op 7537 B/op 1.00
BenchmarkHasLinkWithPatternAndDomainPatternLarge - allocs/op 111 allocs/op 111 allocs/op 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.