Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Adapter supports ctx #1302

Closed
shenghui0779 opened this issue Aug 21, 2023 · 7 comments · Fixed by #1305
Closed

[Feature] Adapter supports ctx #1302

shenghui0779 opened this issue Aug 21, 2023 · 7 comments · Fixed by #1305
Assignees
@hsluoyz
Labels
enhancement
Projects
Casbin Easy Tasks for Beginners/Stude...

Comments

@shenghui0779
Copy link

image
@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang

@hsluoyz
Copy link
Member

hsluoyz commented Aug 21, 2023

@PokIsemaine

@PokIsemaine PokIsemaine mentioned this issue Aug 25, 2023
Merged
@shenghui0779
Copy link
Author

Currently, the context can only be used to control the execution timeout of the adapter and cannot continue to pass down.

@hsluoyz hsluoyz mentioned this issue Oct 24, 2023
Closed
@shenghui0779
Copy link
Author

The adapter's methods cannot use the context passed from external sources internally.

image

@hsluoyz
Copy link
Member

hsluoyz commented Oct 25, 2023

@shenghui0779 ctx is added here: https://github.com/casbin/gorm-adapter/blob/master/context_adapter.go

@shenghui0779
Copy link
Author

shenghui0779 commented Oct 26, 2023 •
edited
Loading

image

Context should be able to pass inward.

@toppercodes
Copy link

+1 I'm in a situation where I need the context in LoadPolicy

@shenghui0779 shenghui0779 mentioned this issue Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement
Projects
Casbin Easy Tasks for Beginners/Stude...
Casbin Easy Tasks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ContextAdapter interface to support context in adapters PokIsemaine/casbin
4 participants
@hsluoyz @shenghui0779 @casbin-bot @toppercodes