Enforcer passes silently a non-existent policy file

[anton-khodak]

https://github.com/casbin/casbin/blob/master/examples/rbac_with_domains_model.conf
https://github.com/casbin/casbin/blob/master/examples/rbac_with_domains_policy.csv

main.go

package main

import "github.com/casbin/casbin"

func main() {
	e := casbin.NewEnforcer("models/rbac_with_domains_model.conf", "models/rbac_with_domains_model.csv")
	e.Enforce("alice","domain1", "data1", "read")
	e.Enforce("admin", "domain1", "data1", "read")
	e.Enforce("alice","domain1", "data1", "write")
	e.Enforce("alice","domain2", "data2", "write")
	e.Enforce("bob", "domain2", "data2", "write")
}

go build main.go output:

2018/11/19 09:15:43 Model:
2018/11/19 09:15:43 e.e: some(where (p_eft == allow))
2018/11/19 09:15:43 m.m: g(r_sub, p_sub, r_dom) && r_dom == p_dom && r_obj == p_obj && r_act == p_act
2018/11/19 09:15:43 g.g: _, _, _
2018/11/19 09:15:43 r.r: sub, dom, obj, act
2018/11/19 09:15:43 p.p: sub, dom, obj, act
2018/11/19 09:15:43 Request: alice, domain1, data1, read ---> false
2018/11/19 09:15:43 Request: admin, domain1, data1, read ---> false
2018/11/19 09:15:43 Request: alice, domain1, data1, write ---> false
2018/11/19 09:15:43 Request: alice, domain2, data2, write ---> false
2018/11/19 09:15:43 Request: bob, domain2, data2, write ---> false

[hsluoyz]

The following test has passed in Travis.

casbin/model_test.go

Lines 149 to 160 in 02f3171

	func TestRBACModelWithDomains(t *testing.T) {
	e := NewEnforcer("examples/rbac_with_domains_model.conf", "examples/rbac_with_domains_policy.csv")
	testDomainEnforce(t, e, "alice", "domain1", "data1", "read", true)
	testDomainEnforce(t, e, "alice", "domain1", "data1", "write", true)
	testDomainEnforce(t, e, "alice", "domain1", "data2", "read", false)
	testDomainEnforce(t, e, "alice", "domain1", "data2", "write", false)
	testDomainEnforce(t, e, "bob", "domain2", "data1", "read", false)
	testDomainEnforce(t, e, "bob", "domain2", "data1", "write", false)
	testDomainEnforce(t, e, "bob", "domain2", "data2", "read", true)
	testDomainEnforce(t, e, "bob", "domain2", "data2", "write", true)
	}

[anton-khodak]

Can you please try running the code above? For some reason, it works OK when paths are absolute, but gives "falses" if paths are relative.

[hsluoyz]

I can't reproduce your error. You need to provide a runnable Git repository, which clearly shows the error.

[anton-khodak]

Oh, the error was that I passed a non-existent file models/rbac_with_domains_model.csv as a policy file. Probably, the enforcer should fail explicitly in this case.

[hsluoyz]

I already encountered the panic, didn't you see it?

C:\GoPath\src\github.com\casbin\casbin\main>go run main.go
panic: open examples/rbac_with_domains_model.conf: The system cannot find the path specified.

goroutine 1 [running]:
github.com/casbin/casbin/model.Model.LoadModel(0xc00006c720, 0x577528, 0x25)
        C:/GoPath/src/github.com/casbin/casbin/model/model.go:96 +0x18e
github.com/casbin/casbin.NewModel(0xc00007dd28, 0x2, 0x2, 0x40bedf)
        C:/GoPath/src/github.com/casbin/casbin/enforcer.go:147 +0x70
github.com/casbin/casbin.(*Enforcer).InitWithAdapter(0xc0000a2000, 0x577528, 0x25, 0x593720, 0xc00004c470)
        C:/GoPath/src/github.com/casbin/casbin/enforcer.go:109 +0x74
github.com/casbin/casbin.(*Enforcer).InitWithFile(0xc0000a2000, 0x577528, 0x25, 0x5771e6, 0x24)
        C:/GoPath/src/github.com/casbin/casbin/enforcer.go:104 +0x8a
github.com/casbin/casbin.NewEnforcer(0xc00007de28, 0x2, 0x2, 0x110)
        C:/GoPath/src/github.com/casbin/casbin/enforcer.go:73 +0x181
main.main()
        C:/GoPath/src/github.com/casbin/casbin/main/main.go:6 +0x8f
exit status 2

[anton-khodak]

It panics on the non-existent model file and passes silently on the non-existent policy file.

[hsluoyz]

This issue is fixed in: 287dc51