Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casbin v2: something wrong with go.mod? #267

Closed
vtolstov opened this issue Jul 12, 2019 · 4 comments
Closed

Casbin v2: something wrong with go.mod? #267

vtolstov opened this issue Jul 12, 2019 · 4 comments
Assignees
Labels

Comments

@vtolstov
Copy link

i'm try to go get github.com/casbin/casbin@v2.0.0
but in local go.mod file i'm always have
github.com/casbin/casbin v0.0.0-20190712023727-2cd38e82a491

@ntrianta
Copy link

For versions v2 and greater, the corresponding changes have to be made in the module declaration of the project according to this specification: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

Could this please be fixed to ensure that workflows can still work?

Thanks!

Nick

@hsluoyz
Copy link
Member

hsluoyz commented Jul 12, 2019

@ntrianta , thanks for the explanation!

@vtolstov , I have provided the fix: cf00986, can you try again?

@hsluoyz hsluoyz self-assigned this Jul 12, 2019
@hsluoyz hsluoyz added the bug label Jul 12, 2019
@vtolstov
Copy link
Author

Yes, nice fix. May be you need to add info to readme that users of this package need to have github.com/casbin/casbin/v2 in import paths

@hsluoyz
Copy link
Member

hsluoyz commented Jul 12, 2019

Actually it is not necessary to update the import path, see this: https://github.com/casbin/xorm-adapter

@hsluoyz hsluoyz closed this as completed Jul 12, 2019
@hsluoyz hsluoyz changed the title something wrong with go.mod? Casbin v2: something wrong with go.mod? Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants