Concurrency issues with custom adapter #323

rolandjitsu · 2019-11-11T06:16:47Z

I'm not exactly sure if it's because of the custom adapter I use, but I keep getting:

fatal error: concurrent map writes

goroutine 998 [running]:
runtime.throw(0x5ace54, 0x15)
	/tmp/go/1.12.6/go/src/runtime/panic.go:617 +0x5c fp=0x20d18d8 sp=0x20d18c4 pc=0x3ef68
runtime.mapassign_faststr(0x548b60, 0x21bf0e0, 0x5a286e, 0x1, 0x21c6368)
	/tmp/go/1.12.6/go/src/runtime/map_faststr.go:291 +0x424 fp=0x20d1908 sp=0x20d18d8 pc=0x239f8
github.com/casbin/casbin/v2.(*Enforcer).enforce(0x21bcc80, 0x0, 0x0, 0x21cef20, 0x3, 0x3, 0x214920c, 0x5a37da, 0x4)
	/home/pi/go/pkg/mod/github.com/casbin/casbin/v2@v2.1.0/enforcer.go:343 +0x128 fp=0x20d1adc sp=0x20d1908 pc=0x17bd4c
github.com/casbin/casbin/v2.(*Enforcer).Enforce(...)
	/home/pi/go/pkg/mod/github.com/casbin/casbin/v2@v2.1.0/enforcer.go:486
api/auth.(*CasbinConfig).CheckPermission(0x21c8cb0, 0x677dc0, 0x2228410, 0x83, 0x90, 0x0)
	/tmp/go/1.12.6/packages/src/api/auth/casbin_middleware.go:67 +0x154 fp=0x20d1b20 sp=0x20d1adc pc=0x48cb2c
api/auth.CasbinMiddlewareWithConfig.func1.1(0x677dc0, 0x2228410, 0x2228410, 0x21cee01)
	/tmp/go/1.12.6/packages/src/api/auth/casbin_middleware.go:51 +0x64 fp=0x20d1b44 sp=0x20d1b20 pc=0x48e928
api/auth.TokenMiddlewareWithConfig.func1.1(0x677dc0, 0x2228410, 0x4, 0x545890)
	/tmp/go/1.12.6/packages/src/api/auth/token_middleware.go:47 +0xf4 fp=0x20d1b68 sp=0x20d1b44 pc=0x48ed98
github.com/labstack/echo/v4/middleware.JWTWithConfig.func2.1(0x677dc0, 0x2228410, 0x5cb8f0, 0x1000)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/jwt.go:207 +0x32c fp=0x20d1bd8 sp=0x20d1b68 pc=0x38cbe4
github.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1(0x677dc0, 0x2228410, 0x0, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/recover.go:78 +0xc4 fp=0x20d1c00 sp=0x20d1bd8 pc=0x38f558
github.com/labstack/echo/v4/middleware.GzipWithConfig.func1.1(0x677dc0, 0x2228410, 0x0, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/compress.go:92 +0x194 fp=0x20d1c54 sp=0x20d1c00 pc=0x38af30
github.com/labstack/echo/v4/middleware.LoggerWithConfig.func2.1(0x677dc0, 0x2228410, 0x5b0844, 0x1b)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/logger.go:117 +0x134 fp=0x20d1cc0 sp=0x20d1c54 pc=0x38eba4
github.com/labstack/echo/v4/middleware.CORSWithConfig.func1.1(0x677dc0, 0x2228410, 0x8, 0x8)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/cors.go:121 +0x384 fp=0x20d1d74 sp=0x20d1cc0 pc=0x38b6ac
github.com/labstack/echo/v4.(*Echo).ServeHTTP.func1(0x677dc0, 0x2228410, 0x1, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/echo.go:610 +0xec fp=0x20d1d9c sp=0x20d1d74 pc=0x361264
github.com/labstack/echo/v4/middleware.RemoveTrailingSlashWithConfig.func1.1(0x677dc0, 0x2228410, 0x1, 0x2)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/slash.go:118 +0x164 fp=0x20d1de8 sp=0x20d1d9c pc=0x38f7d8
github.com/labstack/echo/v4.(*Echo).ServeHTTP(0x20cc500, 0x672a10, 0x23ba900, 0x2122000)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/echo.go:616 +0x234 fp=0x20d1e10 sp=0x20d1de8 pc=0x359280
net/http.serverHandler.ServeHTTP(0x20a4800, 0x672a10, 0x23ba900, 0x2122000)
	/tmp/go/1.12.6/go/src/net/http/server.go:2774 +0x88 fp=0x20d1e2c sp=0x20d1e10 pc=0x2fa3e0
net/http.(*conn).serve(0x2435260, 0x6733f0, 0x21cfa40)
	/tmp/go/1.12.6/go/src/net/http/server.go:1878 +0x7e4 fp=0x20d1fdc sp=0x20d1e2c pc=0x2f69a0
runtime.goexit()
	/tmp/go/1.12.6/go/src/runtime/asm_arm.s:868 +0x4 fp=0x20d1fdc sp=0x20d1fdc pc=0x6b574
created by net/http.(*Server).Serve
	/tmp/go/1.12.6/go/src/net/http/server.go:2884 +0x298

So it fails around functions[key] = util.GenerateGFunction(rm).

Here's the custom adapter I use:

package auth

import (
	"bufio"
	"errors"
	"os"
	"strings"

	"github.com/casbin/casbin/v2/model"

	"api/user"
)

type Adapter struct {
	fPath string
}

// No AutoSave
// https://casbin.org/docs/en/adapters#how-to-write-an-adapter
// https://github.com/casbin/casbin/blob/master/persist/adapter.go
func (a *Adapter) AddPolicy(sec string, ptype string, rule []string) error {
	return errors.New("Not implemented")
}

func (a *Adapter) RemovePolicy(sec string, ptype string, rule []string) error {
	return errors.New("Not implemented")
}

func (a *Adapter) RemoveFilteredPolicy(sec string, ptype string, fieldIndex int, fieldValues ...string) error {
	return errors.New("Not implemented")
}

func NewAdapter(fPath string) *Adapter {
	return &Adapter{fPath}
}

func (a *Adapter) LoadPolicy(m model.Model) error {
	if err := a.fromFile(m, update); err != nil {
		return err
	}

	f := user.Find()
	if err := f.Error(); err != nil {
		return err
	}

	for _, user := range f.Users() {
		update(m, user.Permissions())
	}

	return nil
}

// TODO: Figure out if we need to save
func (a *Adapter) SavePolicy(m model.Model) error {
	return errors.New("Not implemented")
}

func update(m model.Model, tokens []string) {
	key := tokens[0]
	sec := key[:1]
	m[sec][key].Policy = append(m[sec][key].Policy, tokens[1:])
}

func (a *Adapter) fromFile(m model.Model, h func(model.Model, []string)) error {
	f, err := os.Open(a.fPath)
	if err != nil {
		return err
	}
	defer f.Close()

	scanner := bufio.NewScanner(f)
	for scanner.Scan() {
		p := strings.TrimSpace(scanner.Text())
		// Skip comments and/or empty strings
		if p == "" || strings.HasPrefix(p, "#") {
			continue
		}
		tokens := strings.Split(p, ",")
		for i := 0; i < len(tokens); i++ {
			tokens[i] = strings.TrimSpace(tokens[i])
		}
		h(m, tokens)
	}
	return scanner.Err()
}

And the middleware I use with echo:

package auth

import (
	"github.com/casbin/casbin/v2"
	"github.com/labstack/echo/v4"
	"github.com/labstack/echo/v4/middleware"

	"api/utils"
)

type (
	// Config defines the config for CasbinAuth middleware
	CasbinConfig struct {
		// Skipper defines a function to skip middleware
		Skipper middleware.Skipper

		// Enforcer defines the CasbinAuth main rule.
		// Required.
		Enforcer *casbin.Enforcer
	}
)

var (
	// DefaultCasbinConfig is the default CasbinAuth middleware config
	DefaultCasbinConfig = CasbinConfig{
		Skipper: middleware.DefaultSkipper,
	}
)

// CasbinMiddleware returns a CasbinAuth middleware
func CasbinMiddleware(ce *casbin.Enforcer) echo.MiddlewareFunc {
	c := DefaultCasbinConfig
	c.Enforcer = ce
	return CasbinMiddlewareWithConfig(c)
}

// TODO: Make PR for echo-contrib for jwt support
// CasbinMiddlewareWithConfig returns a CasbinAuth middleware with config
func CasbinMiddlewareWithConfig(config CasbinConfig) echo.MiddlewareFunc {
	// Defaults
	if config.Skipper == nil {
		config.Skipper = DefaultCasbinConfig.Skipper
	}

	return func(next echo.HandlerFunc) echo.HandlerFunc {
		return func(c echo.Context) error {
			if config.Skipper(c) {
				return next(c)
			}

			if pass, err := config.CheckPermission(c); err == nil && pass {
				return next(c)
			} else if err != nil {
				return utils.ServerError(err)
			}

			return echo.ErrForbidden
		}
	}
}

// CheckPermission checks the user/method/path combination from the request.
// Returns true (permission granted) or false (forbidden)
func (a *CasbinConfig) CheckPermission(c echo.Context) (bool, error) {
	username := GetUsername(c)
	req := c.Request()
	return a.Enforcer.Enforce(username, req.URL.Path, req.Method)
}

And the way I init and use it:

func main() {
        e := echo.New()

        // ACL
	// https://echo.labstack.com/middleware/casbin-auth
	a := auth.NewAdapter(os.Getenv("AUTH_POLICY"))
	ce, err := casbin.NewEnforcer(os.Getenv("AUTH_MODEL"), a)
	if err != nil {
		e.Logger.Error(err.Error())
		return
	}

	acl := auth.CasbinMiddlewareWithConfig(auth.CasbinConfig{
		Skipper:  authSkipper,
		Enforcer: ce,
	})
	e.Use(acl)
}

The text was updated successfully, but these errors were encountered:

hsluoyz · 2019-11-11T06:18:02Z

See: https://casbin.org/docs/en/multi-threading

rolandjitsu · 2019-11-11T06:22:36Z

@hsluoyz thanks, will try it out.

rolandjitsu · 2019-11-11T06:34:11Z

Ok, I've been testing for a few minutes and this doesn't seem to work. It still failed after about 100 requests.


goroutine 9 [running]:
runtime.throw(0x5ad740, 0x15)
	/tmp/go/1.12.6/go/src/runtime/panic.go:617 +0x5c fp=0x29458b8 sp=0x29458a4 pc=0x3ef68
runtime.mapassign_faststr(0x548ba0, 0x29bf100, 0x5a310e, 0x1, 0x29c81a8)
	/tmp/go/1.12.6/go/src/runtime/map_faststr.go:291 +0x424 fp=0x29458e8 sp=0x29458b8 pc=0x239f8
github.com/casbin/casbin/v2.(*Enforcer).enforce(0x29bcc80, 0x0, 0x0, 0x298d8c0, 0x3, 0x3, 0x20, 0x519448, 0x1)
	/home/pi/go/pkg/mod/github.com/casbin/casbin/v2@v2.1.0/enforcer.go:343 +0x128 fp=0x2945abc sp=0x29458e8 pc=0x17bd4c
github.com/casbin/casbin/v2.(*Enforcer).Enforce(...)
	/home/pi/go/pkg/mod/github.com/casbin/casbin/v2@v2.1.0/enforcer.go:486
github.com/casbin/casbin/v2.(*SyncedEnforcer).Enforce(0x29bec40, 0x298d8c0, 0x3, 0x3, 0x5a4000, 0x0, 0x0)
	/home/pi/go/pkg/mod/github.com/casbin/casbin/v2@v2.1.0/enforcer_synced.go:111 +0xa0 fp=0x2945ae8 sp=0x2945abc pc=0x17dc24
api/auth.(*CasbinConfig).CheckPermission(0x29c6cb8, 0x678fe0, 0x29b8640, 0x83, 0x90, 0x0)
	/tmp/go/1.12.6/packages/src/api/auth/casbin_middleware.go:68 +0x138 fp=0x2945b20 sp=0x2945ae8 pc=0x491310
api/auth.CasbinMiddlewareWithConfig.func1.1(0x678fe0, 0x29b8640, 0x29b8640, 0x298d801)
	/tmp/go/1.12.6/packages/src/api/auth/casbin_middleware.go:52 +0x64 fp=0x2945b44 sp=0x2945b20 pc=0x49310c
api/auth.TokenMiddlewareWithConfig.func1.1(0x678fe0, 0x29b8640, 0x4, 0x5458d0)
	/tmp/go/1.12.6/packages/src/api/auth/token_middleware.go:47 +0xf4 fp=0x2945b68 sp=0x2945b44 pc=0x49357c
github.com/labstack/echo/v4/middleware.JWTWithConfig.func2.1(0x678fe0, 0x29b8640, 0x5cc250, 0x1000)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/jwt.go:207 +0x32c fp=0x2945bd8 sp=0x2945b68 pc=0x391330
github.com/labstack/echo/v4/middleware.RecoverWithConfig.func1.1(0x678fe0, 0x29b8640, 0x0, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/recover.go:78 +0xc4 fp=0x2945c00 sp=0x2945bd8 pc=0x393ca4
github.com/labstack/echo/v4/middleware.GzipWithConfig.func1.1(0x678fe0, 0x29b8640, 0x0, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/compress.go:92 +0x194 fp=0x2945c54 sp=0x2945c00 pc=0x38f67c
github.com/labstack/echo/v4/middleware.LoggerWithConfig.func2.1(0x678fe0, 0x29b8640, 0x5b1146, 0x1b)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/logger.go:117 +0x134 fp=0x2945cc0 sp=0x2945c54 pc=0x3932f0
github.com/labstack/echo/v4/middleware.CORSWithConfig.func1.1(0x678fe0, 0x29b8640, 0x8, 0x8)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/cors.go:121 +0x384 fp=0x2945d74 sp=0x2945cc0 pc=0x38fdf8
github.com/labstack/echo/v4.(*Echo).ServeHTTP.func1(0x678fe0, 0x29b8640, 0x1, 0x0)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/echo.go:610 +0xec fp=0x2945d9c sp=0x2945d74 pc=0x3659b0
github.com/labstack/echo/v4/middleware.RemoveTrailingSlashWithConfig.func1.1(0x678fe0, 0x29b8640, 0x1, 0x2)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/middleware/slash.go:118 +0x164 fp=0x2945de8 sp=0x2945d9c pc=0x393f24
github.com/labstack/echo/v4.(*Echo).ServeHTTP(0x28cc500, 0x673c28, 0x2aded80, 0x2bf0800)
	/home/pi/go/pkg/mod/github.com/labstack/echo/v4@v4.1.11/echo.go:616 +0x234 fp=0x2945e10 sp=0x2945de8 pc=0x35d9cc
net/http.serverHandler.ServeHTTP(0x28a4800, 0x673c28, 0x2aded80, 0x2bf0800)
	/tmp/go/1.12.6/go/src/net/http/server.go:2774 +0x88 fp=0x2945e2c sp=0x2945e10 pc=0x2feb2c
net/http.(*conn).serve(0x29c4780, 0x674608, 0x29e4ea0)
	/tmp/go/1.12.6/go/src/net/http/server.go:1878 +0x7e4 fp=0x2945fdc sp=0x2945e2c pc=0x2fb0ec
runtime.goexit()
	/tmp/go/1.12.6/go/src/runtime/asm_arm.s:868 +0x4 fp=0x2945fdc sp=0x2945fdc pc=0x6b574
created by net/http.(*Server).Serve
	/tmp/go/1.12.6/go/src/net/http/server.go:2884 +0x298

hsluoyz · 2019-11-11T06:45:31Z

Change:

functions := e.fm

into:

var functions model.FunctionMap
for k, v := range e.fm {
	functions[k] = v
}

See if it fixed.

rolandjitsu · 2019-11-11T06:49:46Z

Do you mean clone the lib and change that line?

hsluoyz · 2019-11-11T06:52:10Z

Can you apply these lines into your source code as a hot fix to see it solves the issue? If yes, I will push it to master. Where your source code is depends on whether you use GOPATH or Go modules.

rolandjitsu · 2019-11-11T09:36:00Z

I've been testing it for the past 30 mins and it seems to be stable with the change you suggested. I could make a PR with the fix.

hsluoyz · 2019-11-11T12:03:05Z

Please do it.

fix: fix function mapping in concurrent envs and close #323

rolandjitsu · 2019-11-12T04:51:39Z

@hsluoyz when do you plan to make a release?

hsluoyz · 2019-11-12T04:54:07Z

Released v2.1.1: https://github.com/casbin/casbin/releases/tag/v2.1.1

rolandjitsu mentioned this issue Nov 11, 2019

Concurrency and thread safety nanomsg/mangos#115

Closed

hsluoyz self-assigned this Nov 11, 2019

hsluoyz added the bug label Nov 11, 2019

hsluoyz closed this as completed in 86847cf Nov 12, 2019

hsluoyz added a commit that referenced this issue Nov 12, 2019

Merge pull request #325 from transcelestial/master

d708484

fix: fix function mapping in concurrent envs and close #323

venliong mentioned this issue Nov 14, 2019

fatal error: concurrent map writes 崩溃 LyricTian/gin-admin#51

Open

postulha mentioned this issue Jun 2, 2020

perf: Use read lock in synced enforcer #479

Merged

hatch1994 mentioned this issue Aug 2, 2020

casbin自定义权限模型BUG，多个协程并发读写map，造成线程(协程)安全问题 go-admin-team/go-admin#181

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Concurrency issues with custom adapter #323

Concurrency issues with custom adapter #323

rolandjitsu commented Nov 11, 2019

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019 •

edited

Loading

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019 •

edited

Loading

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 12, 2019

hsluoyz commented Nov 12, 2019

Concurrency issues with custom adapter #323

Concurrency issues with custom adapter #323

Comments

rolandjitsu commented Nov 11, 2019

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019 • edited Loading

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 11, 2019 • edited Loading

hsluoyz commented Nov 11, 2019

rolandjitsu commented Nov 12, 2019

hsluoyz commented Nov 12, 2019

rolandjitsu commented Nov 11, 2019 •

edited

Loading

rolandjitsu commented Nov 11, 2019 •

edited

Loading