-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lock less when syncing #988
Conversation
@tangyang9464 @closetool @sagilio please review |
@tangyang9464 plz review |
// Wait for at least one sync | ||
time.Sleep(time.Millisecond * 300) | ||
|
||
testEnforceSync(t, e, "bob", "data2", "write", true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this as otherwise this test was also passing when the policy reloading failed.
@johanneswuerbach plz fix: |
59f633e
to
a9d0bd2
Compare
Thanks @hsluoyz, should be fixed now. |
a9d0bd2
to
8a1a8a6
Compare
@tangyang9464 plz review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions please check out
8a1a8a6
to
ea3dfd0
Compare
ea3dfd0
to
60fcd04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 2.44.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This reverts commit 756b994.
Lock the
SyncedEnforcer
only when replacing the model and not during the entire policy reload duration.Fixes #987