Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GetDomainsForUser() API #746

Merged
merged 1 commit into from Apr 7, 2021
Merged

feat: Add GetDomainsForUser() API #746

merged 1 commit into from Apr 7, 2021

Conversation

uran0sH
Copy link
Contributor

@uran0sH uran0sH commented Mar 30, 2021

Fix: #744

@hsluoyz hsluoyz requested a review from abichinger March 30, 2021 11:23
@hsluoyz
Copy link
Member

hsluoyz commented Mar 30, 2021

@thoraj please review.

@thoraj
Copy link

thoraj commented Mar 30, 2021

@thoraj please review.

I'm happy to see this added. And I'm happy to test and provide feedback. But unfortunately I'm not familiar with Go, and I could not find any release or pre-release of Casbin.net.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 30, 2021

@thoraj can you just see if the test case output is expected for the model and policy? If that's good to go, we will port the exactly the same logic to .NET

image

Signed-off-by: RobotHuang <1183598761@qq.com>
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 2.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hsluoyz
Copy link
Member

hsluoyz commented Apr 7, 2021

@RobotHuang please add the new APIs to the official docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetDomainsForUser() API
4 participants