feat: pass all policies on effector interface #902
Conversation
Signed-off-by: phoenixsqf <sqfphoenix@163.com>
|
@tangyang9464 @closetool @sagilio please review |
| @@ -655,7 +655,7 @@ func (e *Enforcer) enforce(matcher string, explains *[]string, rvals ...interfac | |||
| policyEffects[0] = effector.Indeterminate | |||
| } | |||
|
|
|||
| effect, explainIndex, err = e.eft.MergeEffects(e.model["e"][eType].Value, policyEffects, matcherResults, 0, 1) | |||
| effect, explainIndex, err = e.eft.MergeEffects(e.model["e"][eType].Value, policyEffects, matcherResults, 0, nil) | |||
There was a problem hiding this comment.
here should be 1. It don't needs to be modified.
There was a problem hiding this comment.
@tangyang9464 Hello.
I modified effector interface param (policyLength int) -> (policies [][]string). And I could get all policies in effector.
In this condition, the policyLen is 0. It means theres no policy in enforcer.So I think it the policyLen shold be 0 rather than 1.
There was a problem hiding this comment.
@phoenixsqf see how Golang implements it.
|
|
Signed-off-by: phoenixsqf sqfphoenix@163.com
Support: #876