fix: signup logic when email and phone not enabled #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chinggg <24590067+chinggg@users.noreply.github.com>
|
@chinggg good finding! Yes, please remove |
hsluoyz
pushed a commit
that referenced
this pull request
Sep 21, 2021
Signed-off-by: chinggg <24590067+chinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsSignupItemEnabledfails to do what it should do. It just check the existence of an item inapplication.SignupItems.But the
SignupItemswill always have all the items, even those items which are not visible or required. So I useIsSignupItemVisibleinstead.In fact, an item is actually enabled only if it is visible, so
IsSignupItemEnabledis of no use. Can we just remove it?