fix: some minor bugs and make Dockerfile more productive.

[atompi]

These are some very minor changes, so no demos are provided.

Make Dockerfile more productive.

• Build all-in-one image:

docker build --target ALLINONE -t casbin/casdoor-all-in-one:latest .

• Build standard image:

docker build --target STANDARD -t casbin/casdoor:latest .

Solve the problem that the PermissionList page jumped abnormally when clicking the permission name in the list.

• Insert the owner into the url when jumping to the permissions details page.

Fix incorrect SignupApplication field value in initBuiltInUser.

• Wrong SignupApplication value causes exceptions in multiple functions for the first admin user, such as uploading avatars, user detail pages, etc.

[casbin-bot]

@Steve0x2a @seriouszyx @Abingcbc @ComradeProgrammer please review

[hsluoyz]

@ComradeProgrammer plz review

[ComradeProgrammer]

Sorry, I cannot see why these changes are applied to dockerfile.

1. What kind of benefits can we get by spiliting ALLINONE into ALLINONE_DB or ALLINONE because few people build them together
2. There are a lot of things omitted which exist in old version, and I doubt whether this is proper , for example, RUN apk add ca-certificates && update-ca-certificates

[atompi]

Sorry, I cannot see why these changes are applied to dockerfile.

1. What kind of benefits can we get by spiliting ALLINONE into ALLINONE_DB or ALLINONE because few people build them together
2. There are a lot of things omitted which exist in old version, and I doubt whether this is proper , for example, RUN apk add ca-certificates && update-ca-certificates

This PR has more changes to the Dockerfile and they are all meaningful changes.

1. The all-in-one image contains a mariadb-server, and installing the mariadb-server via apt has no dependencies on other build steps, and stripping it out of ALLINONE makes the Dockerfile look hierarchical. Also, placing STANDARD before ALLINONE eliminates the need to build ALLINONE images when building STANDARD images, which greatly optimizes the experience when building STANDARD images.
2. There are many unnecessary shell commands in the old Dockerfile, such as install ca-certificates && update-ca-certificates. When we use debian:lates or alpine:latest as the base image, /etc/ssl/certs/ca-certificates.crt already contains the latest ca certificates, and we don't need to perform an update operation every time we build.
3. When we start mariadb with the service mariadb start command, mariadb is usually ready for service after this command ends normally and we no longer need the wait-for-it shell utility to perform the wait operation.
4. Wrapping a large number of instructions in a CMD is usually not a wise decision. Splitting this section into a separate entrypoint script allows for a clearer CMD structure, while using exec in the entrypoint script to start the service allows the processes in the container to be associated with the container lifecycle.

[ComradeProgrammer]

I see the reason why you made these change, and these productive changes will be accepted.

But one more thing:

After you used 'STANDARD' as the new target of standard image, ci configuration of this repository also needs to be changed. please modify .github/workflows/build.yml as well

[atompi]

I see the reason why you made these change, and these productive changes will be accepted.

But one more thing:

After you used 'STANDARD' as the new target of standard image, ci configuration of this repository also needs to be changed. please modify .github/workflows/build.yml as well

Thanks for your recognition, I've pushed the changes to .github/workflows/build.yml, please review them again.

[hsluoyz]

@ComradeProgrammer plz review

[ComradeProgrammer]

Thanks for your recognition, I've pushed the changes to .github/workflows/build.yml, please review them again.

Well I just tried this dockerfile and something went wrong.
When I execute docker build --target ALLINONE -t casbin/casdoor-all-in-one:latest .
I see

failed to solve with frontend dockerfile.v0: failed to create LLB definition: failed to parse stage name "ALLINONE_DB": invalid reference format: repository name must be lowercase

It seems that FROM ALLINONE_DB AS ALLINONE is not accepted

Is it because that this requires a newer version of docker?

[atompi]

docker build --target ALLINONE -t casbin/casdoor-all-in-one:latest .

I found a similar problem here. I am working fine with Docker CE 20.10.8 and 17.05 in Ubuntu 20.04. Perhaps there are some differences between Linux and MacOS. I've pushed the adaptability changes to PR and also added target to docker-compose.yml to use the correct stage for the build, please review them again. Thanks!

[hsluoyz]

@atompi thanks for the contribution! Can you also help fix the Dockerfile for Casnode? https://github.com/casbin/casnode/blob/master/Dockerfile

[casbin-bot]

🎉 This PR is included in version 1.62.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[atompi]

@atompi thanks for the contribution! Can you also help fix the Dockerfile for Casnode? https://github.com/casbin/casnode/blob/master/Dockerfile

Of course! I am very honored and I will finish this tomorrow.

[hsluoyz]

Hi @atompi may I ask why you make PR to this repo? Are you applying for some program?

[atompi]

Hi @atompi may I ask why you make PR to this repo? Are you applying for some program?

@hsluoyz No, I didn't apply for any project, I just encountered some problems in the process of using it and solved them as I went along.

[hsluoyz]

@atompi great! Look forward to your contribution!