-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support SAML okta login #149
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wasabi <690898835@qq.com>
feat: add linkedin provider
Signed-off-by: ErikQQY <2283984853@qq.com>
fix: Update yarn.lock
ebreak
force-pushed
the
master
branch
2 times, most recently
from
July 9, 2021 15:52
0b1b0a9
to
27dd0ed
Compare
Signed-off-by: ErikQQY <2283984853@qq.com>
fix: Change commit author to casbin bot
Signed-off-by: killer <1533063601@qq.com>
feat: Add log table and record all user behaviors into the table, add UI to view logs
Signed-off-by: MRGUOKING <420919469@qq.com> The count-down will be disabled after sending the code Signed-off-by: MRGUOKING <420919469@qq.com>
fix: The count-down will be disabled
Signed-off-by: killer <1533063601@qq.com>
feat: add run casdoor through docker
Signed-off-by: turbodog03 <63595854+turbodog03@users.noreply.github.com>
feat: add language select box and background color change when hover
Signed-off-by: WindSpiritSR <simon343riley@gmail.com>
fix: db data init and frontend warning
Signed-off-by: WindSpiritSR <simon343riley@gmail.com>
Signed-off-by: killer <1533063601@qq.com>
fix: Fix the user list cannot be displayed completely
Signed-off-by: Kininaru <shiftregister233@outlook.com>
Signed-off-by: Kininaru <shiftregister233@outlook.com>
feat: auto login session will expire after 24h
Signed-off-by: Kininaru <shiftregister233@outlook.com> typo
Signed-off-by: Kininaru <shiftregister233@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented all steps of SAML auth, and it can already sign in via SAML (Okta).
But there are still some problems.
1. I can not find any keyword to prove that the xml comes from SAML server
Okta Auth server redirected to Casdoor with a xml file like this:
I can not find any keyword to prove that this request comes from the SAML server.
Anyone can write this xml, and send it to Casdoor to declare their identity.
2. SAML server will let browsers make POST requests when redirecting to Casdoor
React can not handle a POST request, so I made a new api
/api/saml-callback
in Go back-end to handle the redirection from a SAML server. And now it works fine.But I wonder if this is a more suitable way to solve the situation...
This is a draft PR, because I want to get some suggestions...
Here is a video of the whole process.
2021-07-06.23-47-57.mp4