fix: Upgrading import paths for casbin/v2 and fixing travis #11
Conversation
hiteshsethi
force-pushed
the
master
branch
2 times, most recently
from
f94eaa5
to
5113a95
Compare
hiteshsethi
changed the title
1. update casbin import paths to v2 2. used go mod to have strict vendor dependency 3. fixed travis ci, added makefile, resolved lint issues Signed-off-by: hiteshsethi <hitesh.28jan@gmail.com>
|
cc: @hsluoyz |
There was a problem hiding this comment.
Could you change travis into github action, like https://github.com/casbin/gorm-adapter/blob/master/.github/workflows/ci.yml
|
@closetool we can switch to GitHub Actions in next PR. @hiteshsethi |
…ndency Signed-off-by: hiteshsethi <hitesh.28jan@gmail.com>
.travis.yml
Outdated
| @@ -3,6 +3,7 @@ language: go | |||
| sudo: required | |||
|
|
|||
| go: | |||
| - "1.14" | |||
There was a problem hiding this comment.
Remove this change. 1.14 is too too old.
There was a problem hiding this comment.
Do you want to consider writing 1.16 here?
|
@hiteshsethi I suggest installing latest Go 1.16.x and then do the PR again. |
|
review comments are fixed |
I've been using go1.15.6 |
|
For:
|
|
Did this because of |
|
I suggesting using latest. |
Signed-off-by: hiteshsethi <hitesh.28jan@gmail.com>
|
@hsluoyz any changes left? |
|
lgtm |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR fixes: