fix: use CSV parsing instead of string splitting for built-in file adapter #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the function of reading the CSV file in the constructor of fileaAdapter and processed it. |
hsluoyz
requested changes
Apr 4, 2021
src/main/java/org/casbin/jcasbin/persist/file_adapter/FileAdapter.java
Outdated
Show resolved
Hide resolved
|
@shy1st plz sign off:
|
shy1st
changed the title
I have fixed it. |
|
Owing to the fact that I modified the loadPolicyLine function in the Helper.Maybe other projects need to be modified as well, such as jdbcAdapter.What do you think of this problem? @hsluoyz |
hsluoyz
requested changes
Apr 5, 2021
|
@shy1st I don't know why we are changing the interface. We will NOT change the the interface. Plz only modify the file adapter class code. If anything doesn't fit your need, just implement your own utility functions inside the class. |
shy1st
force-pushed
the
master
branch
3 times, most recently
from
eac327e
to
37ae1b0
Compare
hsluoyz
requested changes
Apr 17, 2021
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| package org.casbin.jcasbin.main; | |||
|
|
|||
| import org.apache.commons.csv.CSVFormat; | |||
| @@ -14,13 +14,14 @@ | |||
|
|
|||
| package org.casbin.jcasbin.main; | |||
|
|
|||
| import org.apache.commons.csv.CSVFormat; | |||
| import org.apache.commons.csv.CSVParser; | |||
src/test/java/org/casbin/jcasbin/main/SyncedEnforcerUnitTest.java
Outdated
Show resolved
Hide resolved
shy1st
force-pushed
the
master
branch
2 times, most recently
from
dbd35d3
to
2dc18bd
Compare
shy1st
changed the title
hsluoyz
approved these changes
Apr 19, 2021
hsluoyz
changed the title
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #158