Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for Enforcer pass FilteredAdapter will load all policy #197

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

rongfengliang
Copy link
Contributor

No description provided.

@rongfengliang rongfengliang changed the title fix: Enforcer pass FilteredAdapter will load all policy fix: Enforcer pass FilteredAdapter will load all policy Jun 9, 2021
@rongfengliang rongfengliang changed the title fix: Enforcer pass FilteredAdapter will load all policy fix: Bug Fixes for Enforcer pass FilteredAdapter will load all policy Jun 9, 2021
@rongfengliang rongfengliang changed the title fix: Bug Fixes for Enforcer pass FilteredAdapter will load all policy fix: for Enforcer pass FilteredAdapter will load all policy Jun 9, 2021
@shink
Copy link
Member

shink commented Jun 9, 2021

@rongfengliang You can commit again with the commit message -- "fix: for Enforcer pass FilteredAdapter will load all policy".

@rongfengliang
Copy link
Contributor Author

rongfengliang commented Jun 9, 2021

@rongfengliang You can commit again with the commit message -- "fix: for Enforcer pass FilteredAdapter will load all policy".

yes. i'm fixing commit format

@shink
Copy link
Member

shink commented Jun 9, 2021

@rongfengliang I think you can squash all the commits into one, because some of the commit messages do not meet the specification.
image

@rongfengliang
Copy link
Contributor Author

yes. l known but current github is too slow for push

Signed-off-by: rong fengliang <1141591465@qq.com>
@rongfengliang
Copy link
Contributor Author

@shink i have fixed it

@shink
Copy link
Member

shink commented Jun 9, 2021

@rongfengliang Can you describe what problems you encountered? Thank you.

@rongfengliang
Copy link
Contributor Author

rongfengliang commented Jun 9, 2021

just like golang version. for java we should not call load all policy when create one enforcer instance if we pass one filterdadapter .

@codecov-commenter
Copy link

Codecov Report

Merging #197 (c61a1ab) into master (be38837) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   64.92%   64.87%   -0.06%     
==========================================
  Files          38       38              
  Lines        1990     1990              
  Branches      349      349              
==========================================
- Hits         1292     1291       -1     
  Misses        591      591              
- Partials      107      108       +1     
Impacted Files Coverage Δ
...rc/main/java/org/casbin/jcasbin/main/Enforcer.java 86.32% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be38837...c61a1ab. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Jun 10, 2021

@rongfengliang which PR do you refer to in Go?

@rongfengliang
Copy link
Contributor Author

@hsluoyz
Copy link
Member

hsluoyz commented Jun 10, 2021

@fangzhengjin @shy1st plz review.

@hsluoyz hsluoyz merged commit f52df3d into casbin:master Jun 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants