-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: for Enforcer pass FilteredAdapter will load all policy #197
Conversation
@rongfengliang You can commit again with the commit message -- "fix: for Enforcer pass FilteredAdapter will load all policy". |
yes. i'm fixing commit format |
@rongfengliang I think you can squash all the commits into one, because some of the commit messages do not meet the specification. |
yes. l known but current github is too slow for push |
Signed-off-by: rong fengliang <1141591465@qq.com>
@shink i have fixed it |
@rongfengliang Can you describe what problems you encountered? Thank you. |
just like golang version. for java we should not call load all policy when create one enforcer instance if we pass one filterdadapter . |
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 64.92% 64.87% -0.06%
==========================================
Files 38 38
Lines 1990 1990
Branches 349 349
==========================================
- Hits 1292 1291 -1
Misses 591 591
- Partials 107 108 +1
Continue to review full report at Codecov.
|
@rongfengliang which PR do you refer to in Go? |
@fangzhengjin @shy1st plz review. |
🎉 This PR is included in version 1.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.