Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update WatcherEx interface #342

Merged
merged 3 commits into from
May 29, 2023
Merged

feat: update WatcherEx interface #342

merged 3 commits into from
May 29, 2023

Conversation

PokIsemaine
Copy link
Member

feat: update WatcherEx interface
a part of #340

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #342 (cd02491) into master (b8df7d8) will decrease coverage by 0.05%.
The diff coverage is 42.42%.

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   69.33%   69.28%   -0.05%     
==========================================
  Files          48       49       +1     
  Lines        2214     2230      +16     
  Branches      409      405       -4     
==========================================
+ Hits         1535     1545      +10     
- Misses        561      570       +9     
+ Partials      118      115       -3     
Impacted Files Coverage Δ
...java/org/casbin/jcasbin/main/InternalEnforcer.java 49.07% <17.39%> (-1.88%) ⬇️
...ain/java/org/casbin/jcasbin/persist/WatcherEx.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PokIsemaine PokIsemaine marked this pull request as draft May 28, 2023 02:59
@PokIsemaine PokIsemaine marked this pull request as ready for review May 28, 2023 08:13
@PokIsemaine
Copy link
Member Author

PokIsemaine commented May 28, 2023

need some suggestions about codeclimate.
I tried refactoring three versions and none of them passed codeclimate
image

The problem goes back and forth between similar blocks of code and the function being too complex. Because I tried to reduce similar code blocks and extracted a notifyWatcher function, but it seems easy to complicate (for codeclimate)

@hsluoyz hsluoyz merged commit d9564ef into casbin:master May 29, 2023
1 check passed
@github-actions
Copy link

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants