Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change logger to slf4j #37

Merged
merged 1 commit into from
Jun 18, 2019
Merged

change logger to slf4j #37

merged 1 commit into from
Jun 18, 2019

Conversation

DemianTinkiel
Copy link
Contributor

Fixes #36

@hsluoyz
Copy link
Member

hsluoyz commented Jun 18, 2019

lgtm.

@hsluoyz hsluoyz merged commit e5d1d27 into casbin:master Jun 18, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 197

  • 4 of 9 (44.44%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 81.641%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/org/casbin/jcasbin/util/Util.java 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
src/main/java/org/casbin/jcasbin/util/Util.java 1 73.85%
Totals Coverage Status
Change from base Build 195: -0.5%
Covered Lines: 836
Relevant Lines: 1024
💛 - Coveralls

@DemianTinkiel DemianTinkiel deleted the slf4j branch June 19, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use slf4j
3 participants
@DemianTinkiel @hsluoyz @coveralls