Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up basic project structure #29

Closed
wants to merge 1 commit into from

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Jun 19, 2022

feat: set up basic project structure

Part of casbin/k8s-gatekeeper#2

@casbin-bot
Copy link
Member

@ashish493 @sagilio please review

@sagilio sagilio self-assigned this Jun 19, 2022
@sagilio sagilio added the enhancement New feature or request label Jun 19, 2022
@sagilio
Copy link
Member

sagilio commented Jun 19, 2022

@ComradeProgrammer This PR will make the README obsolescent, it is not suitable to remove or keep it. I think we need to create a new branch for development.

We can try to merge to this branch later:
https://github.com/casbin/k8s-authz/tree/develop

@sagilio sagilio changed the base branch from master to develop June 19, 2022 10:11
Copy link
Member

@sagilio sagilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most change LGTM and A few issues are better to resolve later.

hack/boilerplate.go.txt Outdated Show resolved Hide resolved
internal/handler/handler.go Outdated Show resolved Hide resolved
internal/handler/handler.go Outdated Show resolved Hide resolved
internal/handler/handler.go Outdated Show resolved Hide resolved
cmd/webhook/main.go Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Jun 19, 2022

Maybe we should use a new repo to hold this code. See comment: casbin/k8s-gatekeeper#1

Closed here.

@hsluoyz hsluoyz closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants