Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add basic tests #6

Merged
merged 6 commits into from
Jun 12, 2021
Merged

test: Add basic tests #6

merged 6 commits into from
Jun 12, 2021

Conversation

ashish493
Copy link
Member

@hsluoyz ,
Work done:-

  • Removed the background from the logo
  • Changed the link to the docs
  • Added basic tests for server and webhook

Next, I will try to add tests for cheking the policy and validation.

While, I was running the deployment file on a minikube cluster, I encountered few bugs which were caused due to migration of v1beta to v1. Since, v1beta is now deprecated, I would be following this guide to fix those in my next PR.

ashish493 and others added 6 commits May 28, 2021 12:41
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
@ashish493
Copy link
Member Author

I'm not able to sign this commit since this was done through github web. I tried rebasing it but still no success :( Hope, it will be ok?

@hsluoyz
Copy link
Member

hsluoyz commented Jun 12, 2021

@ashish493 great! Can you add GitHub Actions CI to run these tests?

@hsluoyz hsluoyz merged commit 0ac85c1 into casbin:master Jun 12, 2021
@ashish493
Copy link
Member Author

ashish493 commented Jun 12, 2021

Can you add GitHub Actions CI to run these tests?

Sure, I found some CIs related to k8s, I will further look into it and try to implement it here.

@github-actions
Copy link

github-actions bot commented Jul 7, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants