feat: Add Github actions CI #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
ashish493
commented
Jun 17, 2021
hsluoyz
requested changes
Jun 18, 2021
Signed-off-by: Ashish Malik <b218008@iiit-bh.ac.in>
|
Made the necessary changes! I used the gofmt to style the code, but still it is showing that it is not yet formatted in the goreportcard- https://goreportcard.com/report/github.com/ashish493/k8s-authz |
hsluoyz
approved these changes
Jun 18, 2021
|
@ashish493 goreportcard is too slow at my side. And I don't think it's 100% correct. Let's merge first and see how it goes. |
Yeah, its really very slow. Also, the CI badge is not rendered properly, I will replace it in the next PR. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #7
@hsluoyz ,
Added the CI for build, lints, tests and for semantic release.
Added goreportcard,coverall and CI build badges for Readme
Fixed the minor bugs.
As of now, build is passing successfully. However, the lints are failing because of some tests related issues. I also have to add an e2e test to check complete working of our application.
I will be doing these tasks in my next PR.