Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casbin@3.0.1 is 18mb instead of the previous 2mb #78

Closed
rictorres opened this issue Jul 5, 2019 · 7 comments
Closed

casbin@3.0.1 is 18mb instead of the previous 2mb #78

rictorres opened this issue Jul 5, 2019 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@rictorres
Copy link
Contributor

rictorres commented Jul 5, 2019

hi, there.

i've noticed that after cab0ceb landed we now have jscodeshift as a dependency, the issue is that this module has 17mb.

we're heavy users of casbin inside lambdas however having a single function with 18mb+ is extremely bad in terms of performance.

must we use jscodeshift?

thanks in advance :)

image

@hsluoyz
Copy link
Member

hsluoyz commented Jul 5, 2019

@nodece

@hsluoyz
Copy link
Member

hsluoyz commented Jul 5, 2019

Hi @rictorres , BTW, can you tell me where to get the image size as your picture? I want to add a badge in the repo's README to show the package size, as an alert :)

@rictorres
Copy link
Contributor Author

rictorres commented Jul 5, 2019

@hsluoyz the image has a link to https://packagephobia.now.sh/result?p=casbin :)

badge:

[![install size](https://packagephobia.now.sh/badge?p=casbin)](https://packagephobia.now.sh/result?p=casbin)

install size

nice idea to put the badge in the readme file! 🚀

@hsluoyz
Copy link
Member

hsluoyz commented Jul 5, 2019

Thanks! Already added: https://github.com/casbin/node-casbin#node-casbin

We will fix this issue and publish a new release soon.

@rictorres
Copy link
Contributor Author

awesome news! thanks, man :D

@hsluoyz
Copy link
Member

hsluoyz commented Jul 6, 2019

Hi @rictorres , we have released v3.0.2:

image

@hsluoyz hsluoyz closed this as completed Jul 6, 2019
@hsluoyz hsluoyz self-assigned this Jul 6, 2019
@hsluoyz hsluoyz added the bug Something isn't working label Jul 6, 2019
@rictorres
Copy link
Contributor Author

beautiful! thanks again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants