fix bug and overload method #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
snowliy
commented
Aug 25, 2018
snowliy
commented
- 🐛 fix 2 array equals' bug;
- 🎨 overload 3 methods.
Pull Request Test Coverage Report for Build 61
💛 - Coveralls |
hsluoyz
reviewed
Aug 25, 2018
| @@ -511,8 +511,9 @@ export class Enforcer { | |||
| /** | |||
| * addPolicy adds a rule to the current policy. | |||
| */ | |||
| public async addPolicy(sec: string | any[], key?: string, rule?: string[]): Promise<boolean> { | |||
| if (typeof sec === 'string' && key && rule) { | |||
| public async addPolicy(...params: any[]): Promise<boolean> { | |||
There was a problem hiding this comment.
Why is this changed? The parameters become unclear now.
| } | ||
| } | ||
|
|
||
| /** | ||
| * removePolicy removes a rule from the current policy. | ||
| */ | ||
| public async removePolicy(sec: string | any[], key?: string, rule?: string[]): Promise<boolean> { | ||
| if (typeof sec === 'string' && key && rule) { | ||
| public async removePolicy(...params: any[]): Promise<boolean> { |
There was a problem hiding this comment.
Why is this changed? The parameters become unclear now.
| public async removeFilteredPolicy(sec: string | number, key: string | string[], fieldIndex?: number, fieldValues?: string[]): Promise<boolean> { | ||
| if (typeof sec === 'string' && typeof key === 'string' && fieldIndex && fieldValues instanceof Array) { | ||
| // public async removeFilteredPolicy(sec: string | number, key: string | string[], fieldIndex?: number, fieldValues?: string[]): Promise<boolean> { | ||
| public async removeFilteredPolicy(...params: any[]): Promise<boolean> { |
There was a problem hiding this comment.
Why is this changed? The parameters become unclear now.
There was a problem hiding this comment.
Like go APIs:
In Public AddPolicy method, overload private addPolicy method.
| @@ -807,7 +808,7 @@ export class Enforcer { | |||
| * @param params the "p" policy rule. | |||
| * @return succeeds or not. | |||
| */ | |||
| public async addNamedPolicy(ptype: string, params: any[]): Promise<boolean> { | |||
| public async addNamedPolicy(ptype: string, ...params: any[]): Promise<boolean> { | |||
| @@ -825,7 +826,7 @@ export class Enforcer { | |||
| * @param params the "p" policy rule. | |||
| * @return succeeds or not. | |||
| */ | |||
| public async removeNamedPolicy(ptype: string, params: any[]): Promise<boolean> { | |||
| public async removeNamedPolicy(ptype: string, ...params: any[]): Promise<boolean> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.