Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement enforceEx() #133

Closed
hsluoyz opened this issue Mar 31, 2021 · 4 comments · Fixed by #134
Closed

Implement enforceEx() #133

hsluoyz opened this issue Mar 31, 2021 · 4 comments · Fixed by #134
Assignees
Labels
enhancement New feature or request released

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 31, 2021

Why is this necessary: #46

See the Go code as a reference implementation: https://casbin.org/docs/en/management-api#enforceex

@hsluoyz hsluoyz self-assigned this Mar 31, 2021
@hsluoyz hsluoyz added the enhancement New feature or request label Mar 31, 2021
@Zxilly
Copy link
Contributor

Zxilly commented Apr 2, 2021

@hsluoyz In fact, I have same opinion with @divyagar at #46 (comment)
Enforce is the core of casbin, made another enforce may make user feel confused.
Maybe we should add an util function to get the reason of deny or allow.

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 2, 2021

@Zxilly Casbin doesn't store enforcement history, so there's no easy way to call another function to get reason. It's also not good for parallel.

EnforceEx() is nearly already a decided thing, which is available in Go Casbin and the docs: https://casbin.org/docs/en/management-api#enforceex

I don't see a strong motive to break it.

@Zxilly
Copy link
Contributor

Zxilly commented Apr 3, 2021

@hsluoyz got it, working on this

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 6, 2021

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants